Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus dependencies to align with AppWrapper #70

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Sep 30, 2024

Issue link

N/A

What changes have been made

Update Prometheus dependencies to align with AppWrapper.
Related discussion: project-codeflare/codeflare-operator#617 (comment)

Verification steps

Verified manually by running ODH integration tests.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for doing this.

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrove-oss, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 11fd6e3 into project-codeflare:main Sep 30, 2024
3 checks passed
@sutaakar sutaakar deleted the prometheus branch October 1, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants