-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appwrappers to v0.25.0 #617
Update appwrappers to v0.25.0 #617
Conversation
f4f9e40
to
284831b
Compare
Changes: + Add age printcolumn + Update to Kueue 0.8.1 + autopilot: add TESTING NoSchedule taint to default config
284831b
to
4b8b66e
Compare
// These replace directives deal with the backlevel ODH kueue version | ||
replace sigs.k8s.io/kueue v0.8.1 => github.com/opendatahub-io/kueue v0.7.0-odh-2 | ||
|
||
replace github.com/prometheus/common v0.57.0 => github.com/prometheus/common v0.46.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed just because codeflare-common
depends on older version of prometheus or are there other components requiring this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prometheus/common replace is because of codeflare-common. It probably should be updated there but I'm not sure how far that change would ripple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I think the change scope should be limited
will update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR ready - project-codeflare/codeflare-common#70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #619 to finish the cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9c10a6a
into
project-codeflare:main
Changes: