-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial e2e tests #136
Initial e2e tests #136
Conversation
Skipping CI for Draft Pull Request. |
@astefanutti Would it have sense to add comments to the tests describing what functionality is tested in specific tests? Something like a description from test strategy ADR. |
@sutaakar yes, absolutely. We can start with commenting the test case functions, and research ways to structure more that information in the next cycles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions. I'm unfamiliar with golang testing.
Done with 2045c7a. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds e2e tests for the CodeFlare stack, more specifically, MCAD, KubeRay/Ray and the CodeFlare SDK.
It includes:
(only runs on OpenShift, requires K8s Support for SDK codeflare-sdk#146)
The execution of the e2e workflow currently takes around 14 minutes on average. A third of that execution time corresponds to the build of the operator container image, which may be optimised in the future, by caching layers for example.
Fixes #4.