Operator Redesign #216
Merged
Operator Redesign #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2023
Closed
|
/hold |
|
/assign @anishasthana @KPostOffice @sutaakar |
KPostOffice
reviewed
Sep 18, 2023
sutaakar
reviewed
Sep 19, 2023
|
Looks good to me once comments are addressed |
|
/unhold |
There was a problem hiding this comment.
/lgtm from my perspective. We can merge it once @KPostOffice and @sutaakar have approved it. (I'm not approving it myself as that would result in the PR merging)
|
/lgtm |
|
this /lgtm as well |
|
/lgtm |
dimakis
reviewed
Sep 20, 2023
anishasthana
approved these changes
Sep 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit bba2c57
into
project-codeflare:main
8 checks passed
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #279.
Closes #281.