-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator Redesign #216
Operator Redesign #216
Conversation
/hold |
/assign @anishasthana @KPostOffice @sutaakar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just a couple of questions
Looks good to me once comments are addressed |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm from my perspective. We can merge it once @KPostOffice and @sutaakar have approved it. (I'm not approving it myself as that would result in the PR merging)
/lgtm |
this /lgtm as well |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
great work Antonin
the e2e tests fail for me locally but seen to pass in the CI so it may just be my env
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bba2c57
into
project-codeflare:main
Part of #279.
Closes #281.