[8.x] Import and export modalForm.js so it is included in the rollup build #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, modalForm.js was not included in the rollup build, which meant that applications with forms in the modal would not work properly, even if they had the required data-blacklight-modal=trigger To confirm the fix, you can run: npm install && npm run prepare && grep triggerFormSelector app/assets/javascripts/blacklight/blacklight.js If you get a match, that means that the file is included in the javascript build and applications can use it. Co-authored-by: Christina Chortaria <[email protected]>
christinach
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, modalForm.js was not included in the rollup build, which meant that applications with forms in the modal would not work properly, even if they had the required
data-blacklight-modal=triggerTo confirm the fix, you can run:
If you get a match, that means that the file is included in the javascript build and applications can use it.
This affects both the release-8.x branch and main. It is blocking our upgrade to Blacklight 8 (see pulibrary/orangelight#4567). We will also open up a pull request for main.