Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklight 8: Record page Feedback Options #4567

Closed
Tracked by #4573 ...
kevinreiss opened this issue Nov 13, 2024 · 3 comments · Fixed by #4636
Closed
Tracked by #4573 ...

Blacklight 8: Record page Feedback Options #4567

kevinreiss opened this issue Nov 13, 2024 · 3 comments · Fixed by #4636
Assignees
Labels
bug 🐛 The application does not work as expected because of a defect

Comments

@kevinreiss
Copy link
Member

kevinreiss commented Nov 13, 2024

Expected behavior

When using one of the three record record page feedback options:

  1. Ask a Question
  2. Suggest a Correction
  3. Report Harmful Language

I expect to click on the option see a modal window, submit my inquiry and be taken back to the record page.

Actual behavior

Include screenshots, or links and browser version if relevant
Screenshot 2024-11-13 at 3 59 38 PM

If I select any of these three options, and submit the modal form I am taken to a blank page rather than the record page. The screenshot below is what you'll see:

suggestion

Steps to replicate

  1. Checkout the blacklight 8 branch
  2. Visit https://catalog.princeton.edu/catalog/99125105012606421
  3. Select "Suggest a Correction"
  4. Submit the Form that appears
  5. You'll be taken to a blank page.

Impact of this bug

Data submitted goes to the appropriate libanswers queue but the user experience is confusing.

Implementation notes, if any

Noting that if you submit these forms on staging the submissions will actually go into libanswers.

There is some potentially related discussion in the #blacklight channel on the code4lib slack.

@kevinreiss kevinreiss added bug 🐛 The application does not work as expected because of a defect sudden-priority labels Nov 13, 2024
@sandbergja
Copy link
Member

@winsice-ng pointed out a potentially related ticket #3945. It's not quite the same issue, since in that case, the input is invalid and there is a NoMethodError. In this case, there is no NoMethodError -- but definitely potentially related!

This was referenced Nov 14, 2024
@sandbergja sandbergja changed the title Record page Feedback Options Blacklight 8: Record page Feedback Options Nov 25, 2024
@rladdusaw rladdusaw assigned rladdusaw and unassigned rladdusaw Dec 4, 2024
@christinach christinach self-assigned this Dec 9, 2024
@christinach
Copy link
Member

@sandbergja and I resolved the issue upstream.
See: projectblacklight/blacklight#3467 and
projectblacklight/blacklight#3466

We pinned the Blacklight upgrade branch to release-8.x until there is a new release for blacklight 8.7

@christinach
Copy link
Member

We still need to do some more work. We're noticing that the event is not added when the modal is loaded.

christinach added a commit that referenced this issue Dec 12, 2024
Update send button to have data attribute bl-dismiss

Co-authored-by: Jane Sandberg <[email protected]>
sandbergja added a commit that referenced this issue Dec 12, 2024
[#4567]Include remove: true in the feedback options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 The application does not work as expected because of a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants