[WIP] Replace bootstrap-tagsinput with Tom Select #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
2890-bootstrap-tagsinput-replacement
branch
from
130795a
to
fffb0b3
Compare
bootstrap-tagsinput is unsupported and out of date. Tom Select supports using a text input, has a similar method of loading remote data, and has both Bootstrap 4 and 5 assets. Vendoring the assets for now, but if we change the asset pipeline for Spotlight v4 perhaps we can remove that.
taylor-steve
force-pushed
the
2890-bootstrap-tagsinput-replacement
branch
from
fffb0b3
to
1e85361
Compare
|
This seems like a huge addition for a small feature. Have you also considered adapting https://github.com/sul-dlss/argo/blob/main/app/javascript/controllers/text_extraction_controller.js ? |
|
It certainly looks huge. It's ~70 lines, 30 of which are config. The rest are vendor files because we lack a clean way to incorporate those in a different fashion (AFAIK). I wasn't aware of that code, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chasing seemingly unrelated test ghosts locally, let's see what CI says...
bootstrap-tagsinput is unsupported and out of date. Tom Select supports using a text input, has a similar method of loading remote data, and has both Bootstrap 4 and 5 assets. Vendoring the assets for now, but if we change the asset pipeline for Spotlight v4 perhaps we can remove that.