-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABM language #1354
base: main
Are you sure you want to change the base?
ABM language #1354
Conversation
…ion, which calculates the next position the agent will move. move_forward function, which moves the agent forward by specified amount. move_backward function, which moves the agent backwards by specified amount. turn_right function, turns the agent right by specified degree. turn_left function, turns the agent left by specified degree.
…d parameters. set_pos function, sets the current position to the specified pos parameter. distancexy function, gives you the distance of the agent and the given coordinate. distance function, gives you the distance between the agent and another agent.
…he grid. towardsxy function, calculates angle between a given coordinate and horizon as if the current position is the origin. towards function, calculates angle between an agent and horizon as if the current position is the origin. facexy function, makes agent face a given coordinate. face function, makes agent face another agent
As stated in #1278 (comment), the methods should be defined in a new class that inherits from |
Also, as stated in #1278 (comment). |
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
- Coverage 91.03% 89.10% -1.94%
==========================================
Files 19 18 -1
Lines 1339 1395 +56
Branches 257 261 +4
==========================================
+ Hits 1219 1243 +24
- Misses 85 117 +32
Partials 35 35
Continue to review full report at Codecov.
|
Thanks @GaelLucero for continuing to work on this. We are here to help so don't hesitate to ask any clarifying questions if one of our comments doesn't make sense or we can even jump on a quick video chat if you want. This is a big project much bigger than a typical first contribution. |
Looks quite awesome @GaelLucero! Are you still working on this? Anything that needs to be discussed? |
I'm still interested in this. Maybe we can create some subclass called "PhysicalSpace" or "NewtonianSpace", which implements movement and direction but also energy, momentum and power. |
Per discussion creating additional pull request for ABM improvement as discussed in PR #1278