Richer access checks #9553
Draft
Richer access checks #9553
+1,857
−314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
catalog-enriched-access-checks
branch
11 times, most recently
from
270a8c0
to
14d3c65
Compare
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 19, 2024
The change projectnessie#9553 has to pass an additional parameter depending on the "receiving API" to the `*ApiImpl` types, which is quite complex to implement with CDI. Therefore this change removes the old `Rest*Service` types and constructs the `*ApiImpl` types directly.
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 19, 2024
The change projectnessie#9553 has to pass an additional parameter depending on the "receiving API" to the `*ApiImpl` types, which is quite complex to implement with CDI. Therefore this change removes the old `Rest*Service` types and constructs the `*ApiImpl` types directly.
snazy
force-pushed
the
catalog-enriched-access-checks
branch
from
14d3c65
to
b13477b
Compare
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 19, 2024
The change projectnessie#9553 has to pass an additional parameter depending on the "receiving API" to the `*ApiImpl` types, which is quite complex to implement with CDI. Therefore this change removes the old `Rest*Service` types and constructs the `*ApiImpl` types directly.
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 19, 2024
The change projectnessie#9553 has to pass an additional parameter depending on the "receiving API" to the `*ApiImpl` types, which is quite complex to implement with CDI. Therefore this change removes the old `Rest*Service` types and constructs the `*ApiImpl` types directly.
snazy
force-pushed
the
catalog-enriched-access-checks
branch
2 times, most recently
from
77b5db9
to
ebf1408
Compare
This was referenced Sep 19, 2024
Nit: Make function to build a Basic Authorization header publicly available (for internal use)
#9578
Closed
snazy
force-pushed
the
catalog-enriched-access-checks
branch
2 times, most recently
from
f1cea06
to
2ecc1c3
Compare
snazy
added a commit
that referenced
this pull request
Sep 20, 2024
The change #9553 has to pass an additional parameter depending on the "receiving API" to the `*ApiImpl` types, which is quite complex to implement with CDI. Therefore this change removes the old `Rest*Service` types and constructs the `*ApiImpl` types directly.
snazy
force-pushed
the
catalog-enriched-access-checks
branch
from
2ecc1c3
to
494a336
Compare
This change introduces the ability to distinguish individual checks by the (external) API being used (Nessie, Iceberg) and for Nessie Catalog (Iceberg REST) to information about the kind(s) of changes being applied. The individual changes that can be distinguished are: * Catalog API operation * Metadata update actions, with special actions wrt to the `location` property * Snapshot operation * Snapshot summary extracts (for example whether a snapshot added or removed data/delete files) All new attributes can be retrieved from the existing `Check` type via new attributes exposed via `AccessCheckMeta` holding the source API, "for write flag" and per-content-key flags. The flags represent the mentioned "individual changes". Fixes projectnessie#9559 (and more)
snazy
force-pushed
the
catalog-enriched-access-checks
branch
from
494a336
to
3018f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to distinguish individual checks by the (external) API being used (Nessie, Iceberg) and for Nessie Catalog (Iceberg REST) to information about the kind(s) of changes being applied.
The individual changes that can be distinguished are:
locationpropertyAll new attributes can be retrieved from the existing
Checktype via new attributes.