Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when liveness probes fails due to full write queue #645

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

vthemelis
Copy link
Contributor

No description provided.

@vthemelis vthemelis force-pushed the log-at-failed-liveness-checks branch from e536245 to c1cb032 Compare May 29, 2024 21:24
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks good in general, just some details to note.

storage/diskmetricstore.go Outdated Show resolved Hide resolved
Signed-off-by: Björn Rabenstein <[email protected]>
@beorn7
Copy link
Member

beorn7 commented Jun 6, 2024

To get this into the next release, I'll apply the suggested changes directly here in the PR.

storage/diskmetricstore.go Outdated Show resolved Hide resolved
Signed-off-by: Björn Rabenstein <[email protected]>
@beorn7 beorn7 merged commit 44fa056 into prometheus:master Jun 6, 2024
4 checks passed
@vthemelis vthemelis deleted the log-at-failed-liveness-checks branch June 6, 2024 19:58
@SuperQ SuperQ mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants