Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when liveness probes fails due to full write queue #645

Merged
merged 3 commits into from
Jun 6, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion storage/diskmetricstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ func (dms *DiskMetricStore) Healthy() error {
// A pushgateway that cannot be written to should not be
// considered as healthy.
if len(dms.writeQueue) == cap(dms.writeQueue) {
return fmt.Errorf("write queue is full")
err := fmt.Errorf("write queue is full")
level.Warn(dms.logger).Log("msg", err)
return err
beorn7 marked this conversation as resolved.
Show resolved Hide resolved
}

return nil
Expand Down