fix(iam): update logic of Root Hardware MFA check #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4726 +/- ##
==========================================
- Coverage 89.10% 89.06% -0.04%
==========================================
Files 913 913
Lines 27913 27912 -1
==========================================
- Hits 24871 24859 -12
- Misses 3042 3053 +11 ☔ View full report in Codecov by Sentry. |
MrCloudSec
deleted the
PRWLR-4412-check-id-iam-root-hardware-mfa-enabled-pass-for-virtual-mfa-device-4652
branch
github-actions
bot
added
the
was-backported
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
MrCloudSec
added a commit
that referenced
this pull request
Aug 16, 2024
(cherry picked from commit e658125) # Conflicts: # tests/providers/aws/services/iam/iam_root_hardware_mfa_enabled/iam_root_hardware_mfa_enabled_test.py
MrCloudSec
added a commit
that referenced
this pull request
Aug 16, 2024
(cherry picked from commit e658125)
jfagoagas
reviewed
Aug 22, 2024
...oviders/aws/services/iam/iam_root_hardware_mfa_enabled/iam_root_hardware_mfa_enabled_test.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix #4652
Description
Update logic of
iam_root_hardware_mfa_enabledcheck so if the ARN of the associated IAM user of the Virtual MFA device is "arn:aws:iam::[aws-account-id]:root", the AWS root account is not using a hardware-based MFA device for MFA protection.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.