fix(iam): update logic of Root Hardware MFA check #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
2 tasks
(cherry picked from commit e658125) # Conflicts: # tests/providers/aws/services/iam/iam_root_hardware_mfa_enabled/iam_root_hardware_mfa_enabled_test.py
MrCloudSec
force-pushed
the
backport/v3/pr-4726
branch
from
ae0cde0 to
6b38b8c
Compare
github-actions
bot
added
the
provider/aws
MrCloudSec
previously approved these changes
Aug 16, 2024
MrCloudSec
approved these changes
Aug 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #4774 +/- ##
==========================================
- Coverage 86.83% 86.82% -0.02%
==========================================
Files 714 714
Lines 22493 22495 +2
==========================================
- Hits 19532 19531 -1
- Misses 2961 2964 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertov3:Questions ?
Please refer to the Backport tool documentation