Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check for unsorted iteration #183

Merged
merged 1 commit into from
Feb 2, 2024
Merged

test: check for unsorted iteration #183

merged 1 commit into from
Feb 2, 2024

Conversation

Eh2406
Copy link
Member

@Eh2406 Eh2406 commented Jan 29, 2024

I had a very difficult day debugging why contains_many did not match contains, turns out my input was not correctly sorted. Similarly, when debugging problems with simplify it would have been nice to easily reject "incorrectly sorted input". (Although that did not turn out to be relevant to the underlying issue.)

This should hopefully be an easy step in the right direction.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Eh2406
Copy link
Member Author

Eh2406 commented Feb 2, 2024

Rebased and cargo fmt.

@Eh2406 Eh2406 added this pull request to the merge queue Feb 2, 2024
Merged via the queue into dev with commit b5eab1d Feb 2, 2024
5 checks passed
@Eh2406 Eh2406 deleted the jf/check_sort branch February 2, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants