[build] Add script for Deeploy environment variables and Makefile info #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viviane <[email protected]>
Signed-off-by: Viviane <[email protected]>
Scheremo
reviewed
Oct 9, 2024
Comment on lines
+1
to
+4
| export PULP_SDK_HOME=${DEEPLOY_INSTALL_DIR}/pulp-sdk | ||
| export LLVM_INSTALL_DIR=${DEEPLOY_INSTALL_DIR}/llvm | ||
| export PULP_RISCV_GCC_TOOLCHAIN= | ||
| export MEMPOOL_HOME=${DEEPLOY_INSTALL_DIR}/mempool |
There was a problem hiding this comment.
You shouldn't just set all these paths relative to DEEPLOY_INSTALL_DIR. The Makefile is set up such that previous installations may be reused, and each tool gets its own DIR variable.
Xeratec
reviewed
Oct 10, 2024
| @@ -72,12 +72,15 @@ echo-bash: | |||
| @echo "TL/DR: add these lines to run ~/.bashrc" | |||
| @echo "export PULP_SDK_HOME=${PULP_SDK_INSTALL_DIR}" | |||
| @echo "export LLVM_INSTALL_DIR=${LLVM_INSTALL_DIR}" | |||
| @echo "export PULP_RISCV_GCC_TOOLCHAIN=/PULP_SDK_IS_A_MESS" | |||
| @echo "export PULP_RISCV_GCC_TOOLCHAIN=" | |||
There was a problem hiding this comment.
Why not completely remove this?
There was a problem hiding this comment.
The pulp-sdk needs the environment variable set afaik but @Scheremo could confirm.
I would prefer if the contents of the variable stay untouched 😏
|
Ciao Viviane, I'd be happy to merge this PR once the feedback from Moritz and Philip is applied and the bash script is moved to the |
Victor-Jung
approved these changes
Oct 28, 2024
|
@viv-eth What is the status of that PR? Should I implement the requested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new script (
deeploy.sh) that sets up essential environment variables for the Deeploy project. TheMakefilehas been updated to reference this script, providing users an easy way to source environment variables directly fromdeeploy.shafter setting up the PULP SDK.Changes:
deeploy.shscript for defining paths to critical tools (LLVM, PULP SDK, QEMU, etc.)Makefileto include instructions on sourcing thedeeploy.shscript for proper environment configurationThis update simplifies the setup process by centralizing environment variables, reducing the need for manual configuration.