-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: backend: Fix ax handshaking req_ready does no longer depend on ax_ready #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure, but there may be some further incorrect handshake dependencies in idma_legalizer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_legalizer.sv#L379-L386
Another may be in idma_axi_transport layer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_axi_transport_layer.sv#L249-L257
I might be wrong, and I don't believe these affect the AXI path, but would be great if you could look at it quickly as well.
f17378f
to
201ec2e
Compare
I agree to lines #L379-L386 in the legalizer. This has to be rewritten at some point (this is anyway planned soon). So far this has never caused any issues so let's create an issue and postpone rewriting until a bug manifests. |
Ok, thanks for checking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, see #6
Issue #6 created. |
No description provided.