Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: backend: Fix ax handshaking req_ready does no longer depend on ax_ready #3

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

thommythomaso
Copy link
Collaborator

No description provided.

@thommythomaso thommythomaso requested a review from micprog August 8, 2022 09:40
@thommythomaso thommythomaso changed the title WIP: Fix ax handshaking req_ready does no longer depend on ax_ready WIP: backend: Fix ax handshaking req_ready does no longer depend on ax_ready Aug 8, 2022
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure, but there may be some further incorrect handshake dependencies in idma_legalizer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_legalizer.sv#L379-L386
Another may be in idma_axi_transport layer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_axi_transport_layer.sv#L249-L257
I might be wrong, and I don't believe these affect the AXI path, but would be great if you could look at it quickly as well.

@thommythomaso thommythomaso force-pushed the fix/backend/ax_handshaking-tbenz branch from f17378f to 201ec2e Compare August 9, 2022 12:01
@thommythomaso
Copy link
Collaborator Author

I am not 100% sure, but there may be some further incorrect handshake dependencies in idma_legalizer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_legalizer.sv#L379-L386 Another may be in idma_axi_transport layer: https://github.com/pulp-platform/iDMA/blob/fix/backend/ax_handshaking-tbenz/src/idma_axi_transport_layer.sv#L249-L257 I might be wrong, and I don't believe these affect the AXI path, but would be great if you could look at it quickly as well.

I agree to lines #L379-L386 in the legalizer. This has to be rewritten at some point (this is anyway planned soon). So far this has never caused any issues so let's create an issue and postpone rewriting until a bug manifests.
The datapath, although looking a bit weird, should be correct.

@micprog
Copy link
Member

micprog commented Aug 9, 2022

I agree to lines #L379-L386 in the legalizer. This has to be rewritten at some point (this is anyway planned soon). So far this has never caused any issues so let's create an issue and postpone rewriting until a bug manifests.
The datapath, although looking a bit weird, should be correct.

Ok, thanks for checking!

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, see #6

@thommythomaso
Copy link
Collaborator Author

Issue #6 created.

@thommythomaso thommythomaso merged commit 2c58674 into master Aug 9, 2022
@thommythomaso thommythomaso deleted the fix/backend/ax_handshaking-tbenz branch August 9, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants