Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #3

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Small fixes #3

merged 4 commits into from
Feb 7, 2024

Conversation

lukamac
Copy link
Collaborator

@lukamac lukamac commented Feb 7, 2024

I fixed a few inconsistencies:

  • stride was still an argument for neureka_task_set_op_to_conv, even though it's not used
  • norm, quant structures didn't have bitwidths specified
  • padding dim order to top, bottom, left, right

@lukamac lukamac requested a review from Scheremo February 7, 2024 14:24
@Scheremo
Copy link

Scheremo commented Feb 7, 2024

LGTM!

@lukamac lukamac merged commit a8765d1 into main Feb 7, 2024
2 checks passed
@lukamac lukamac deleted the small-fixes branch February 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scheremo Scheremo Awaiting requested review from Scheremo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukamac @Scheremo