Non evm support and additional ccr functions integration #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated address params in payload to bytes32 in CCR functions
…03-enable-updatechannelmeta-ccr
403 address to bytes32
…ta-ccr Add CCR support for updateChannelMeta
…CR-support-for-UpdateChannelState
…ngs-ccr feat: add ccr support for createChannelSettings fn
…CR-support-for-UpdateChannelState
…nelState Add CCR for UpdateChannelState
fix test cases and structure
zaryab2000
reviewed
Aug 10, 2024
| @@ -11,7 +11,7 @@ contract PushCoreStorageV2 { | |||
| ); | |||
|
|
|||
| mapping(address => uint256) public nonces; // NOT IN USE Anymore | |||
| mapping(address => uint256) public channelUpdateCounter; | |||
| mapping(address => uint256) public oldChannelUpdateCounter;//NOT in use anymore | |||
There was a problem hiding this comment.
We directly reject the use of old ChannelUpdateCounter mapping but what about the data it already stores for existing addresses ?? Has there any measures been implemented for the migration of those data?
cc: @0xNilesh
There was a problem hiding this comment.
two things here:
- It should first be checked if there are existing use of this
oldChannelUpdateCountercurrently? - We should include functionality for the migration of this data as well from address to bytes.
Note: Ideally, every address to bytes change should be re-checked for migration again. @0xNilesh @Zartaj0
There was a problem hiding this comment.
This might have slipped.
Yes, we planned to include its migration in the same migrate function we have for channelInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.