Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non evm support and additional ccr functions integration #422
Non evm support and additional ccr functions integration #422
Changes from all commits
2e34a3a
0d85aa6
2f92165
e218655
74e1d71
9178079
1777c0b
e809640
321caad
e8e17b1
f93cdb5
9d2f335
5ac31b4
ee59007
48a702e
28d82ad
53b9982
1010ff6
6c9fa98
705b69f
3ede041
79dc380
b60fc89
83a5130
4ed2b4e
fe51df5
35b7639
4a0467e
092be11
db6d027
d3d5a7b
7ad949d
d5661c0
bdd1c05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We directly reject the use of old
ChannelUpdateCounter
mapping but what about the data it already stores for existing addresses ?? Has there any measures been implemented for the migration of those data?cc: @0xNilesh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two things here:
oldChannelUpdateCounter
currently?Note: Ideally, every address to bytes change should be re-checked for migration again. @0xNilesh @Zartaj0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might have slipped.
Yes, we planned to include its migration in the same migrate function we have for
channelInfo
.