Feature/1135 formatter enable rules rebased #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
feature/1135-formatter-enable-rules-rebased
branch
2 times, most recently
from
1139423 to
cb75cb5
Compare
kcinay055679
commented
Dec 23, 2024
frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/shared/custom/scoring/scoring.component.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
Show resolved
Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
Show resolved
Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts
Show resolved
Hide resolved
peggimann
requested changes
Dec 23, 2024
frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/team-management/add-edit-team-dialog/add-edit-team-dialog.component.ts
Outdated
Show resolved
Hide resolved
peggimann
requested changes
Dec 24, 2024
frontend/src/app/components/action-plan/action-plan.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/shared/custom/scoring/scoring.component.spec.ts
Outdated
Show resolved
Hide resolved
nevio18324
force-pushed
the
feature/1135-formatter-enable-rules-rebased
branch
from
2efd083 to
08e3d38
Compare
squash branch update eslint config run formatter fix tests revert to single quotes regen package-lock move eslint dependendencies to devDependencies and update comment in eslint-config remove not needed parent clings fix typo in comment in scoring component tests put both statements inside if statement change asignment of args in global ts add curly to eslint config put curly into quotes update comments to clarify that they are for lint replace multiple ifs with one switch replace multiple ifs with one switch replace multiple ifs with one switch turn no-non-null-assertion off and bring back all usages of add strict equality fix eslint errors remove not needed comment add todo for error handling oauth interceptor update comments so its clear that linter needs them revert change made accidentally fix frontend unit tests revert changes made accidentally bring back all not null assertions and create some switch statements in scoring component for readability
nevio18324
force-pushed
the
feature/1135-formatter-enable-rules-rebased
branch
from
08e3d38 to
643258b
Compare
peggimann
approved these changes
Dec 24, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.