Feature/1135 formatter enable rules rebased

frontend/cypress/e2e/check-in.cy.ts

@@ -17,7 +17,7 @@ describe('okr check-in', () => {
     cy.loginAsUser(users.gl);
   });
 
-  it(`should create check-in metric`, () => {
+  it('should create check-in metric', () => {
     overviewPage
       .addKeyResult()
       .fillKeyResultTitle('Very important keyresult')
@@ -39,7 +39,7 @@ describe('okr check-in', () => {
     cy.contains('We bought a new house');
   });
 
-  it(`should create check-in metric with confidence 0`, () => {
+  it('should create check-in metric with confidence 0', () => {
     overviewPage
       .addKeyResult()
       .fillKeyResultTitle('Very important keyresult')
@@ -61,7 +61,7 @@ describe('okr check-in', () => {
     cy.contains('We bought a new house');
   });
 
-  it(`should create check-in metric with value below baseline`, () => {
+  it('should create check-in metric with value below baseline', () => {
     overviewPage
       .addKeyResult()
       .fillKeyResultTitle('This will not be good')
@@ -249,7 +249,7 @@ describe('okr check-in', () => {
     cy.contains('STRETCH');
   });
 
-  it(`should display confirm dialog when creating check-in on draft objective`, () => {
+  it('should display confirm dialog when creating check-in on draft objective', () => {
     overviewPage.addObjective()
       .fillObjectiveTitle('draft objective title')
       .selectQuarter('3')
@@ -270,7 +270,7 @@ describe('okr check-in', () => {
       .checkDescription('Dein Objective befindet sich noch im DRAFT Status. Möchtest du das Check-in trotzdem erfassen?');
   });
 
-  it(`should only display last value div if last check-in is present`, () => {
+  it('should only display last value div if last check-in is present', () => {
     const objectiveName = uniqueSuffix('new objective');
 
     overviewPage.addObjective()
@@ -310,8 +310,12 @@ function getCurrentDate() {
 
   let dd_str = '' + dd;
   let mm_str = '' + mm;
-  if (dd < 10) dd_str = '0' + dd_str;
-  if (mm < 10) mm_str = '0' + mm_str;
+  if (dd < 10) {
+    dd_str = '0' + dd_str;
+  }
+  if (mm < 10) {
+    mm_str = '0' + mm_str;
+  }
 
   return dd_str + '.' + mm_str + '.' + yyyy;
 }

frontend/cypress/e2e/objective-backlog.cy.ts

@@ -10,7 +10,7 @@ describe('okr objective backlog', () => {
     cy.loginAsUser(users.gl);
   });
 
-  it(`should not have save button when creating objective in backlog quarter`, () => {
+  it('should not have save button when creating objective in backlog quarter', () => {
     overviewPage
       .addObjective()
       .fillObjectiveTitle('Objective in quarter backlog')
@@ -27,7 +27,7 @@ describe('okr objective backlog', () => {
     cy.contains('Objective in quarter backlog');
   });
 
-  it(`should edit objective and move it to backlog`, () => {
+  it('should edit objective and move it to backlog', () => {
     overviewPage.addObjective()
       .fillObjectiveTitle('Move to another quarter on edit')
       .submitDraftObjective();
@@ -50,7 +50,7 @@ describe('okr objective backlog', () => {
     cy.contains('This goes now to backlog');
   });
 
-  it(`should not be able to select backlog quarter when editing ongoing objective`, () => {
+  it('should not be able to select backlog quarter when editing ongoing objective', () => {
     overviewPage.addObjective()
       .fillObjectiveTitle('We can not move this to backlog')
       .submit();
@@ -67,7 +67,7 @@ describe('okr objective backlog', () => {
       .should('not.contain', 'Backlog');
   });
 
-  it(`should release objective to another quarter from backlog`, () => {
+  it('should release objective to another quarter from backlog', () => {
     overviewPage.visitBacklogQuarter();
     overviewPage.addObjective()
       .fillObjectiveTitle('We can not release this')
@@ -105,7 +105,7 @@ describe('okr objective backlog', () => {
     cy.contains('This is our first released objective');
   });
 
-  it(`should edit objective title in backlog`, () => {
+  it('should edit objective title in backlog', () => {
     overviewPage.visitBacklogQuarter();
     overviewPage.addObjective()
       .fillObjectiveTitle('This is possible for edit')
@@ -124,7 +124,7 @@ describe('okr objective backlog', () => {
     overviewPage.getObjectiveByNameAndState('My new title', 'draft');
   });
 
-  it(`should edit objective in backlog and change quarter`, () => {
+  it('should edit objective in backlog and change quarter', () => {
     overviewPage.visitBacklogQuarter();
     overviewPage.addObjective()
       .fillObjectiveTitle('This goes to other quarter later')
@@ -144,7 +144,7 @@ describe('okr objective backlog', () => {
     overviewPage.getObjectiveByNameAndState('This goes to other quarter later', 'draft');
   });
 
-  it(`should duplicate objective in backlog`, () => {
+  it('should duplicate objective in backlog', () => {
     overviewPage.visitBacklogQuarter();
     overviewPage.addObjective()
       .fillObjectiveTitle('Ready for duplicate in backlog')
@@ -189,7 +189,7 @@ describe('okr objective backlog', () => {
       .should('exist');
   });
 
-  it(`should duplicate ongoing objective to backlog`, () => {
+  it('should duplicate ongoing objective to backlog', () => {
     overviewPage.addObjective()
       .fillObjectiveTitle('Possible to duplicate into backlog')
       .submit();

frontend/cypress/e2e/objective-crud.cy.ts

@@ -18,7 +18,7 @@ describe('crud operations', () => {
     'draft-icon.svg']].forEach(([objectiveTitle,
     buttonTestId,
     icon]) => {
-    it(`should create objective without key-results`, () => {
+    it('should create objective without key-results', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle(objectiveTitle)
         .selectQuarter('3');
@@ -32,7 +32,7 @@ describe('crud operations', () => {
     });
   });
 
-  it(`should display error message when title not set`, () => {
+  it('should display error message when title not set', () => {
     overviewPage.addObjective();
     cy.getByTestId('title')
       .first()
@@ -47,7 +47,7 @@ describe('crud operations', () => {
       .should('not.be.disabled');
   });
 
-  it(`should cancel creating an objective`, () => {
+  it('should cancel creating an objective', () => {
     const objectiveTitle = 'this is a canceled objective';
     overviewPage.addObjective()
       .selectQuarter('3')
@@ -57,7 +57,7 @@ describe('crud operations', () => {
       .should('not.exist');
   });
 
-  it(`should delete existing objective`, () => {
+  it('should delete existing objective', () => {
     overviewPage.getFirstObjective()
       .findByTestId('three-dot-menu')
       .click();
@@ -69,15 +69,15 @@ describe('crud operations', () => {
       .submit();
   });
 
-  it(`should open objective detail view via click`, () => {
+  it('should open objective detail view via click', () => {
     overviewPage.getFirstObjective()
       .find('.title')
       .click();
     cy.url()
       .should('include', 'objective');
   });
 
-  it(`should edit objective`, () => {
+  it('should edit objective', () => {
     const updatedTitle = 'This is an updated title';
     overviewPage.getFirstObjective()
       .findByTestId('three-dot-menu')
@@ -90,7 +90,7 @@ describe('crud operations', () => {
       .should('exist');
   });
 
-  it(`should duplicate objective`, () => {
+  it('should duplicate objective', () => {
     const duplicatedTitle = 'This is a duplicated objective';
     overviewPage.getFirstObjective()
       .findByTestId('three-dot-menu')

frontend/cypress/e2e/objective.cy.ts

@@ -11,7 +11,7 @@ describe('okr objective', () => {
   });
 
   describe('tests via click', () => {
-    it(`should release objective from draft to ongoing`, () => {
+    it('should release objective from draft to ongoing', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('A objective in state draft')
         .submitDraftObjective();
@@ -31,7 +31,7 @@ describe('okr objective', () => {
         .should('exist');
     });
 
-    it(`should complete objective with successful`, () => {
+    it('should complete objective with successful', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('We want to complete this successful')
         .submit();
@@ -58,7 +58,7 @@ describe('okr objective', () => {
       overviewPage.getObjectiveByNameAndState('We want to complete this successful', 'successful');
     });
 
-    it(`should complete objective with not-successful`, () => {
+    it('should complete objective with not-successful', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('A not successful objective')
         .submit();
@@ -84,7 +84,7 @@ describe('okr objective', () => {
       overviewPage.getObjectiveByNameAndState('A not successful objective', 'not-successful');
     });
 
-    it(`should reopen successful objective`, () => {
+    it('should reopen successful objective', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('This objective will be reopened after')
         .submit();
@@ -119,7 +119,7 @@ describe('okr objective', () => {
         .should('exist');
     });
 
-    it(`should cancel reopening successful objective`, () => {
+    it('should cancel reopening successful objective', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('The reopening of this objective will be canceled')
         .submit();
@@ -198,7 +198,7 @@ describe('okr objective', () => {
         .should('exist');
     });
 
-    it(`should search and find objectives`, () => {
+    it('should search and find objectives', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('Search after this objective')
         .submit();
@@ -258,7 +258,7 @@ describe('okr objective', () => {
         .should('not.exist');
     });
 
-    it(`should create objective in other quarter`, () => {
+    it('should create objective in other quarter', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('Objective in quarter 3')
         .selectQuarter('3')
@@ -272,7 +272,7 @@ describe('okr objective', () => {
       cy.contains('Objective in quarter 3');
     });
 
-    it(`should edit objective and move it to another quarter`, () => {
+    it('should edit objective and move it to another quarter', () => {
       overviewPage.addObjective()
         .fillObjectiveTitle('Move to another quarter on edit')
         .submit();
@@ -296,7 +296,7 @@ describe('okr objective', () => {
   });
 
   describe('tests via keyboard', () => {
-    it(`should open objective aside via enter`, () => {
+    it('should open objective aside via enter', () => {
       cy.getByTestId('objective')
         .first()
         .find('[tabindex]')

frontend/cypress/e2e/team-management.cy.ts

@@ -304,7 +304,7 @@ describe('okr team-management', () => {
           return true;
         })
         .then(() => {
-          expect(foundEsha).to.be.true;
+          expect(foundEsha).to.equal(true);
         });
     });
 
@@ -461,7 +461,7 @@ describe('okr team-management', () => {
             .trim() !== 'Findus Peterson') {
             return;
           }
-          $row.find(`[data-testId='edit-role']`)
+          $row.find('[data-testId=\'edit-role\']')
             .click();
           cy.wait(500); // wait for dialog to open
         })
@@ -495,7 +495,7 @@ describe('okr team-management', () => {
 
       ConfirmDialog.do()
         .checkTitle('Mitglied entfernen')
-        .checkDescription(`Möchtest du Findus Peterson wirklich aus dem Team '/BBT' entfernen?`)
+        .checkDescription('Möchtest du Findus Peterson wirklich aus dem Team \'/BBT\' entfernen?')
         .submit();
 
       cy.get('app-member-detail')

frontend/cypress/support/commands.ts

@@ -19,19 +19,17 @@ Cypress.Commands.add('getByTestId', (testId: string, text?: string): Chainable =
   }
 });
 
-Cypress.Commands.add('findByTestId',
-  { prevSubject: true },
-  (subject: JQuery<HTMLElement>, testId: string, text?: string): Chainable => {
-    const selector = `[data-testId=${testId}]`;
-    if (text) {
-      return cy.wrap(subject)
-        .find(selector)
-        .contains(text);
-    } else {
-      return cy.wrap(subject)
-        .find(selector);
-    }
-  });
+Cypress.Commands.add('findByTestId', { prevSubject: true }, (subject: JQuery<HTMLElement>, testId: string, text?: string): Chainable => {
+  const selector = `[data-testId=${testId}]`;
+  if (text) {
+    return cy.wrap(subject)
+      .find(selector)
+      .contains(text);
+  } else {
+    return cy.wrap(subject)
+      .find(selector);
+  }
+});
 
 Cypress.Commands.add('pressUntilContains', (text: string, key: keyof typeof keyCodeDefinitions) => {
   pressUntilContains(text, key);

frontend/cypress/support/component.ts

@@ -2,7 +2,7 @@ import './commands';
 import { keyCodeDefinitions } from 'cypress-real-events/keyCodeDefinitions';
 
 declare global {
-  namespace Cypress {
+  export namespace Cypress {
     interface Chainable {
       loginAsUser(user: any): Chainable;
       getByTestId(testsId: string, text?: string): Chainable;

frontend/cypress/support/helper/dom-helper/dialogs/objectiveDialog.ts

@@ -21,7 +21,7 @@ export default class ObjectiveDialog extends Dialog {
 
   toggleCreateKeyResults() {
     cy.getByTestId('keyResult-checkbox')
-      .find("[type='checkbox']")
+      .find('[type=\'checkbox\']')
       .check();
     return this;
   }

frontend/cypress/support/helper/dom-helper/filterHelper.ts

@@ -1,7 +1,9 @@
 import { PageObjectMapperBase } from './pageObjectMapperBase';
 
 export default class FilterHelper extends PageObjectMapperBase {
-  validatePage(): void {}
+  validatePage(): void {
+    // Does not need to be implemented this comment is for making linter happy
+  }
 
   optionShouldBeSelected(text: string, isOnOverview = true): this {
     if (isOnOverview) {

frontend/cypress/support/helper/dom-helper/pages/overviewPage.ts

@@ -196,7 +196,9 @@ export default class CyOverviewPage extends Page {
     return '';
   }
 
-  validatePage(): void {}
+  validatePage(): void {
+    // Does not need to be implemented this comment is for making linter happy
+  }
 
   protected doVisit(): void {
     this.elements.logo()