Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation for Tuto 1 #276

Merged
merged 7 commits into from
Nov 1, 2021
Merged

French translation for Tuto 1 #276

merged 7 commits into from
Nov 1, 2021

Conversation

Tititesouris
Copy link

@Tititesouris Tititesouris commented Oct 28, 2021

Participates in #267

Let me know if you have any feedback.
I had to rephrase some parts to make it easier to understand in French, like adding the notion of "cursor" for the "current location".

Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super début de trad !
Beau boulot et merci 😉

docs/Tutorial.md Show resolved Hide resolved
docs/Tutorial-fr.md Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #276 (46dd76c) into master (9e6811e) will not change coverage.
The diff coverage is n/a.

❗ Current head 46dd76c differs from pull request most recent head 30a88b0. Consider uploading reports for the commit 30a88b0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files          16       16           
  Lines        3821     3821           
  Branches      815      815           
=======================================
  Hits         3328     3328           
  Misses        319      319           
  Partials      174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e6811e...30a88b0. Read the comment docs.

@Tititesouris
Copy link
Author

Changes requested were done. I also noticed that language naming was inconsistent/incorrect in the files. Given that I speak enough German and Spanish to correct those, I did. I left "Italian" alone because I'm not sure what translation should be there instead.

@Lucas-C
Copy link
Member

Lucas-C commented Nov 1, 2021

Thank you! Merging this now

@allcontributors please add @Tititesouris for translation

@allcontributors
Copy link

@Lucas-C

I've put up a pull request to add @Tititesouris! 🎉

@Lucas-C Lucas-C merged commit a084922 into py-pdf:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants