Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuto 2 and 3 translated in French #287

Merged
merged 13 commits into from
Nov 2, 2021
Merged

Conversation

Tititesouris
Copy link

Participates in #267
Just in time before the end of Hacktoberfest, I finished the tutorials 2 and 3. I branched out so that I could create a separate PR, let me know if there are any merging conflicts, I will happily resolve them.

@Lucas-C
Copy link
Member

Lucas-C commented Nov 1, 2021

Hi @Tititesouris

Sorry, this didn't make it for hacktoberfest, I wasn't available after 6pm yesterday.

Still, good job and thank you!

Could you rebase this PR on master please, to fix the merge conflicts?

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #287 (35a8194) into master (c352b82) will not change coverage.
The diff coverage is n/a.

❗ Current head 35a8194 differs from pull request most recent head 068202a. Consider uploading reports for the commit 068202a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files          16       16           
  Lines        3821     3821           
  Branches      815      815           
=======================================
  Hits         3328     3328           
  Misses        319      319           
  Partials      174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c352b82...068202a. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
docs/Tutorial-fr.md Outdated Show resolved Hide resolved
@Lucas-C Lucas-C merged commit eb187c1 into py-pdf:master Nov 2, 2021
@Tititesouris Tititesouris deleted the tuto23 branch November 2, 2021 23:23
@Lucas-C
Copy link
Member

Lucas-C commented Nov 19, 2021

FYI I mentioned you in this blog article 😉
https://chezsoi.org/lucas/blog/hacktoberfest-on-fpdf2.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants