Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images flowing within TextColumns #973

Merged
merged 37 commits into from
Oct 31, 2023
Merged

Conversation

gmischler
Copy link
Collaborator

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.
  • A unit test is covering the code added / modified by this PR
  • This PR is ready to be merged
  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder
  • A mention of the change is present in CHANGELOG.md

This makes it possible to convert table cells to text region as the next step.

It might be worth considering if a FORM_FEED character in the text should trigger a page break in the traditional multi-line text methods.

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (40d64d4) 93.70% compared to head (27f4ee0) 93.79%.

❗ Current head 27f4ee0 differs from pull request most recent head d47fbd9. Consider uploading reports for the commit d47fbd9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   93.70%   93.79%   +0.08%     
==========================================
  Files          28       28              
  Lines        8276     8391     +115     
  Branches     1514     1544      +30     
==========================================
+ Hits         7755     7870     +115     
+ Misses        324      323       -1     
- Partials      197      198       +1     
Files Coverage Δ
fpdf/line_break.py 99.14% <100.00%> (+<0.01%) ⬆️
fpdf/image_parsing.py 84.70% <90.32%> (+0.66%) ⬆️
fpdf/fpdf.py 93.04% <91.04%> (+0.29%) ⬆️
fpdf/text_region.py 93.55% <92.85%> (+0.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C
Copy link
Member

Lucas-C commented Oct 30, 2023

Really good job on this! 👍👍

After that PR, we will be very close to using TextRegions in table.py!

@gmischler gmischler merged commit fb9fd9c into py-pdf:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants