Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: New submission form #113

Closed
wants to merge 3 commits into from
Closed

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jun 6, 2023

No description provided.

@@ -1,39 +1,210 @@
name: DRAFT WIP from a SPRINT - PLEASE DO NOT USE THIS TEMPLATE
name: Submit Software for Review (Draft)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Submit Software for Review (Draft)
name: Submit You Package to pyOpenSci for Review

@@ -1,39 +1,210 @@
name: DRAFT WIP from a SPRINT - PLEASE DO NOT USE THIS TEMPLATE
name: Submit Software for Review (Draft)
description: Use to submit your Python package for pyOpenSci peer review
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Use to submit your Python package for pyOpenSci peer review
description: Use this form to submit your Python package to the pyOpenSci peer review process. If you run into any issues with the form, you can ask questions [on our discourse forum here](https://pyopensci.discourse.group/c/review-process/7).

body:
- type: input
id: "Submitting_Author"
id: "submitting_author"
attributes:
label: Submitting Author
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each person we want two fields.

  1. the persons first and last name
  2. the persons github handle
    if they are separate it will be much easier for me to parse!

so for each form field i'd also provide an example of the format we expect like this:

Submiting author first and last name (e.g. Janet Doe)

label: Current Maintainers
description: list all current maintainers
placeholder: github_handle1, github_handle2
label: Maintainer 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above let's have first and last name and then the github handle for each maintainer.
Let's also allow for up to 5 maintainers and then an open ended box for any additional maintainers they wish to add.

placeholder: Package name here
validations:
required: true
- type: input
id: "One_line_desc"
id: "one_line_desc"
attributes:
label: One-Line Description of Package
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: One-Line Description of Package
label: One-Line Description of Package (please try to avoid using overly technical terms if possible for this one line entry)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally they avoid jargon so we can use this in our social media from the start! we could also say "please provide and easy-to-understand one-line description of your package here"

Comment on lines 48 to 50
label: Repository Link
description: Link to the package repository
placeholder: Link here
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Repository Link
description: Link to the package repository
placeholder: Link here
label: Repository Link
description: Please provide a link to your package's GitHub / GitLab repository.
placeholder: Repository link here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is what the user sees? is the description under the label?

placeholder: Link here
validations:
required: true
- type: input
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have them add the version number submitted and ALSO a link to that version of the repo so it would either be a link to a tag/ release or a commit value. so there should be two fields here.

validations:
required: true
- type: checkboxes
id: terms
attributes:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent!!

Comment on lines 71 to 72
- label: I expect to maintain this package for at least 2 years and can help find a replacement for the maintainer (team) if needed.
required: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: I expect to maintain this package for at least 2 years and can help find a replacement for the maintainer (team) if needed.
required: true
- label: I expect to maintain this package for at least 2 years. In the case that I need to step down as a maintainer, i'm open to supporting finding a replacement maintainer (team) if needed / if it makes sense for my package.
required: true

Comment on lines 73 to 75
- label: I have read the [author guide](https://www.pyopensci.org/software-peer-review/how-to/author-guide.html).
required: true
- type: textarea
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: I have read the [author guide](https://www.pyopensci.org/software-peer-review/how-to/author-guide.html).
required: true
- type: textarea
- label: I have read the [pyOS peer review author guide](https://www.pyopensci.org/software-peer-review/how-to/author-guide.html).
required: true
- type: textarea

Comment on lines 78 to 81
label: Description
description: Include a brief paragraph describing what your package does
placeholder: Description here
validations:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Description
description: Include a brief paragraph describing what your package does
placeholder: Description here
validations:
label: Description
description: Please provide a brief and easy-to-understand paragraph describing what your package does. Please try to avoid jargon or define jargon to make it clear to our cross-domain editorial team what your package does.
placeholder: Easy-to-understand package description here.
validations:

Comment on lines 87 to 88
description: "Please select one or more categories. Check out our [package scope page](https://www.pyopensci.org/software-peer-review/about/package-scope.html) to learn more about our scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):"
options:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Please select one or more categories. Check out our [package scope page](https://www.pyopensci.org/software-peer-review/about/package-scope.html) to learn more about our scope. (If you are unsure of which category you fit, we suggest you make a pre-submission inquiry):"
options:
description: "Please select one or more categories. Check out our [package scope page](https://www.pyopensci.org/software-peer-review/about/package-scope.html) to learn more about our scope. (If you are unsure of which category you fit, we suggest that you make a pre-submission inquiry):"
options:

- label: Database interoperability
- type: checkboxes
id: "partnerships"
attributes:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanis2112 can we add markdown to this form to break up sections with lines / rules? that would be great for this section. i want to add some clarifying language here and also we will have more communities in the future coming on board so i want to ensure that this section is flexible.

- type: checkboxes
id: "partnerships"
attributes:
label: Domain Specific & Community Partnerships
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so right now this section i know is confusing for users. so let's break it up. let's add

Does your package fit into the categories below? (this is optional - it is ok if it doesn't. We use this information to help our package users find packages with functionality that they need).  
- geospatial
- education

SO then let's add a section called community partnerships like this:

## Community partnerships
pyOpenSci [partners with communities](https://www.pyopensci.org/software-peer-review/partners/scientific-communities.html#pyopensci-software-peer-review-partnerships) that are maintaining lists of affiliated packages. You do not need to be a part of a community or to fall into a specific domain to apply for peer review. However if you are a part of the community we will vet your tool against both our pyOpenSci standards and the community specific standards.

I would like to be affiliated with a community listed below. (check the box if you believe meet the community affiliation requirements):
- I wish to be considered to be Pangeo affiliated. I have [read the pangeo requirements](https://www.pyopensci.org/software-peer-review/partners/pangeo.html#pangeo-specific-software-peer-review-guidelines) and believe my package follows them.  

if this is confusing language we can reword - but i'd like this to be a section so we can just add communities as they come onboard and direct authors to the requirements for that community. but we also want to be clear that people don't HAVE to be a part of the community to go into review (i've been asked this a few times hence i'd like to add text that this is OPTIONAL)

- type: textarea
id: "category_explanation"
attributes:
label: Category explanation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we want to make this three boxes so it's super clear and easy to fill out.

Package scope questions

  1. Please describe the target audience of this package
  2. what are the scientific applications of this package
  3. Are there any other python packages that accomplish the same thing? (yes / no)
    • if yes - provide a box to explain what packages and why
  4. if you made a pre-submission please past the link here.

Comment on lines 135 to 141
label: Technical Checks
description: "For details about the pyOpenSci packaging requirements, see our [packaging guide](https://www.pyopensci.org/python-package-guide/). Confirm each of the following by checking the box. This package: "
options:
- label: does not violate the Terms of Service of any service it interacts with.
required: false
- label: "uses an [OSI approved license](https://opensource.org/licenses)."
required: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Technical Checks
description: "For details about the pyOpenSci packaging requirements, see our [packaging guide](https://www.pyopensci.org/python-package-guide/). Confirm each of the following by checking the box. This package: "
options:
- label: does not violate the Terms of Service of any service it interacts with.
required: false
- label: "uses an [OSI approved license](https://opensource.org/licenses)."
required: false
label: Package Technical Checks
description: "For details about the pyOpenSci packaging requirements, see our [packaging guide](https://www.pyopensci.org/python-package-guide/). Confirm each of the following by checking the box. This package: "
options:
- label: does not violate the Terms of Service of any service it interacts with.
required: false
- label: "uses an [OSI approved license](https://opensource.org/licenses)."
required: false

Comment on lines 142 to 143
- label: contains a README with instructions for installing the development version.
required: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: contains a README with instructions for installing the development version.
required: false
- label: contains a README file with instructions for creating an environment for and installing the development version of the package.
required: false

Comment on lines 144 to 146
- label: includes documentation with examples for all functions.
required: false
- label: contains a tutorial with examples of its essential functions and uses.
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: includes documentation with examples for all functions.
required: false
- label: contains a tutorial with examples of its essential functions and uses.
- label: includes documentation with examples for all functions & methods. (examples in your docstring are optional but encouraged)
required: false
- label: contains a get-started tutorial with examples of using the package's essential functions and applications.

Comment on lines 150 to 151
- label: has continuous integration setup, such as GitHub Actions, CircleCI, and/or others.
required: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- label: has continuous integration setup, such as GitHub Actions, CircleCI, and/or others.
required: false
- label: has continuous integration setup to run tests, such as GitHub Actions, CircleCI, and/or others.
required: false

Comment on lines 156 to 159
description: "Do you wish to automatically submit to the [Journal of Open Source Software](http://joss.theoj.org/)?"
options:
- I want to automatically submit to JOSS.
- I don't want to automatically submit to JOSS.
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a new section as well. title it

## Journal of Open Source (JOSS) Partnership Submission
pyOpenSci partners with JOSS. This means that JOSS accepts our review as theirs and will only review your paper if your package is within the JOSS scope. 

Note that this is not automatic. so removing that language here

Suggested change
description: "Do you wish to automatically submit to the [Journal of Open Source Software](http://joss.theoj.org/)?"
options:
- I want to automatically submit to JOSS.
- I don't want to automatically submit to JOSS.
description: "Do you wish to submit to the [Journal of Open Source Software](http://joss.theoj.org/) when the pyOS review is complete?"
options:
- I want to submit to JOSS.
- I don't want to submit to JOSS.

Comment on lines +166 to +167
description: "If you want to automatically submit your package to JOSS, please confirm each of the following by checking the box:"
options:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "If you want to automatically submit your package to JOSS, please confirm each of the following by checking the box:"
options:
description: "JOSS has a slightly more refined scope than that of pyOpenSci. If you want to submit your package to JOSS, please use the links below to determine whether your package is in JOSS' scope. Check each box that applies. NOTE: JOSS will make the final determination of scope into their ecosystem. These checks are here to help prepare you for their process and guidelines. "
options:

options:
- I want to automatically submit to JOSS.
- I don't want to automatically submit to JOSS.
validations:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original issue template we have this section as a section that you can "unfold" if you are interested in JOSS. Can we add that same format to this form?

Screen Shot 2023-06-06 at 2 07 53 PM

- label: "The package is deposited in a long-term repository with the DOI listed below."
required: false
- type: input
id: "package_doi"
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a new section as well. this is the section that the editor fills out when the review is over. section name:

Post review metadata (to be filled out by an editor)

Comment on lines +175 to +179
required: false
- label: "The package is deposited in a long-term repository with the DOI listed below."
required: false
- type: input
id: "package_doi"
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this explanation text to this section:

At the end of our reviews we ask that you create a final tagged release associated with the review that is linked to a zenodo archive (or some other archive of your choice). An editor will ask you to provide that link when the review is complete. The link will be added here.  

attributes:
label: Feedback
description: "Have feedback/comments about our review process? Leave a comment the [pyOpenSci Discourse](https://pyopensci.discourse.group/c/review-process/7)."
options:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feedback portion doesn't have to be a question with a check box - it can just be text at the bottom of the issue.

required: false
- type: input
id: "package_doi"
attributes:
Copy link
Member Author

@lwasser lwasser Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to add a second link to the JOSS archive IF they submitted to JOSS. again this will be filled in at the END of the review but we like this information at the top of the issue.

so the DOI archive question should be there and then below the JOSS archive (optional and only if they submit to joss)

@lwasser
Copy link
Member Author

lwasser commented Mar 11, 2024

closing this as stale as well

@lwasser lwasser closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants