-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emission of events from root validators and extraneous emission of dependent fields #234
Conversation
CodSpeed Performance ReportMerging #234 will not alter performanceComparing Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 1829 1843 +14
=========================================
+ Hits 1829 1843 +14
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the fast fix. Just made a couple of nit-picking comments on implementation comment naming, which are optional.
As discussed in #233, it probably also makes sense to rename |
Co-authored-by: Andy Sweet <[email protected]>
Co-authored-by: Andy Sweet <[email protected]>
Co-authored-by: Andy Sweet <[email protected]>
agreed, did you have a thought on the exact name? As mentioned over there:
|
…sygnal into fix-root-validators
`property_dependencies` was renamed to `field_dependencies` in pyapp-kit#234 but some associated error messages and docs still refer to the deprecated name.
`property_dependencies` was renamed to `field_dependencies` in #234 but some associated error messages and docs still refer to the deprecated name.
fixes #233
@andy-sweet, this implements option number 2 from #233 (comment)
property_dependencies
can include any field names ... not just property setters