Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more idaklu solver options #4249

Closed
wants to merge 69 commits into from
Closed

Add more idaklu solver options #4249

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
f66db40
Bump to v24.5rc0
Saransh-cpp May 1, 2024
c6a48e8
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
Saransh-cpp Jun 25, 2024
139776e
Update publish_pypi.yml
Saransh-cpp Jun 25, 2024
d8745c8
Remove T flag
kratman Jun 25, 2024
8fc5fd4
(feat): more idaklu options
MarcBerliner Jul 8, 2024
e25db2a
Update CasadiSolverOpenMP.cpp
MarcBerliner Jul 8, 2024
2934ff8
Revert "Update CasadiSolverOpenMP.cpp"
MarcBerliner Jul 8, 2024
6f75ea2
Update CHANGELOG.md
MarcBerliner Jul 8, 2024
5392a6a
stricter tolerances on tests
MarcBerliner Jul 8, 2024
d3cc479
fix tests for macos12 and ubuntu
MarcBerliner Jul 8, 2024
da2fe61
Merge branch 'develop' into idaklu-options
MarcBerliner Jul 9, 2024
20e1334
Update pybamm/solvers/idaklu_solver.py
MarcBerliner Jul 11, 2024
5e220e9
style: pre-commit fixes
pre-commit-ci[bot] Jul 11, 2024
0dc7a47
Update pybamm/solvers/idaklu_solver.py
MarcBerliner Jul 11, 2024
c85e503
remove unnecessary `enumerate`
MarcBerliner Jul 11, 2024
83c4267
split `Options` into `SetupOptions` and `SolverOptions`
MarcBerliner Jul 11, 2024
1c021a5
Merge branch 'develop' into idaklu-options
MarcBerliner Jul 11, 2024
b01db78
Fix pointer issues and added const
kratman Jul 11, 2024
b5bc7b5
(feat): more idaklu options
MarcBerliner Jul 8, 2024
0fcd738
Update CasadiSolverOpenMP.cpp
MarcBerliner Jul 8, 2024
8e80887
Revert "Update CasadiSolverOpenMP.cpp"
MarcBerliner Jul 8, 2024
56ca9eb
Update CHANGELOG.md
MarcBerliner Jul 8, 2024
f0c5a50
stricter tolerances on tests
MarcBerliner Jul 8, 2024
1578770
fix tests for macos12 and ubuntu
MarcBerliner Jul 8, 2024
ae64817
Update pybamm/solvers/idaklu_solver.py
MarcBerliner Jul 11, 2024
320f1dd
style: pre-commit fixes
pre-commit-ci[bot] Jul 11, 2024
db684e9
Update pybamm/solvers/idaklu_solver.py
MarcBerliner Jul 11, 2024
003aae3
remove unnecessary `enumerate`
MarcBerliner Jul 11, 2024
df5ae3f
split `Options` into `SetupOptions` and `SolverOptions`
MarcBerliner Jul 11, 2024
fc97188
Fix pointer issues and added const
kratman Jul 11, 2024
61eacc6
Fix another minor warning
kratman Jul 11, 2024
37b1973
Merge branch 'idaklu-options' of https://github.com/MarcBerliner/PyBa…
MarcBerliner Jul 11, 2024
c71fa5e
Revert "Merge branch 'idaklu-options' of https://github.com/MarcBerli…
MarcBerliner Jul 11, 2024
dad1509
Fixes for sympy (#4253)
kratman Jul 9, 2024
ba2f7a0
Fix test pypi worflow (#4217)
kratman Jul 10, 2024
1e582fd
Make function for handling time or reuse an existing one (#4209)
mleot Jul 1, 2024
c7ea22f
Issue 4224 duration bug (#4239)
valentinsulzer Jul 11, 2024
d4c5413
Fix package directory
kratman Jul 12, 2024
2442907
Update version
kratman Jul 12, 2024
313e182
bug fixes, add tests
MarcBerliner Jul 12, 2024
276a31e
Apply suggestions from code review
MarcBerliner Jul 12, 2024
7443243
Add support for MLIR-based expression evaluation (#4199)
jsbrittain Jul 15, 2024
ae77c74
Fix directory (#4263)
Saransh-cpp Jul 15, 2024
640c9f8
Bump github/codeql-action from 3.25.11 to 3.25.12 in the actions grou…
dependabot[bot] Jul 15, 2024
6c1a559
chore: update pre-commit hooks (#4269)
pre-commit-ci[bot] Jul 15, 2024
4796ba9
Moving a bunch of unit tests to pytest. (#4264)
prady0t Jul 16, 2024
9afe45e
Using `tempfile` for `standard_model_test` (#4270)
prady0t Jul 16, 2024
fe39f99
Merge branch 'develop' into v24.5rc2
kratman Jul 17, 2024
740fa50
Merge pull request #4259 from pybamm-team/v24.5rc2
kratman Jul 18, 2024
27c29df
fix degradation options when one of the phases has no degradation (#4…
valentinsulzer Jul 18, 2024
ed412f8
Removing false flagging of assert statements from tests. (#4236)
prady0t Jul 19, 2024
8e338bc
(feat): more idaklu options
MarcBerliner Jul 8, 2024
99e029b
Update CasadiSolverOpenMP.cpp
MarcBerliner Jul 8, 2024
8a1a0ed
Revert "Update CasadiSolverOpenMP.cpp"
MarcBerliner Jul 8, 2024
9be2344
Update CHANGELOG.md
MarcBerliner Jul 8, 2024
1c46de3
stricter tolerances on tests
MarcBerliner Jul 8, 2024
ad767a8
fix tests for macos12 and ubuntu
MarcBerliner Jul 8, 2024
de2e85e
remove unnecessary `enumerate`
MarcBerliner Jul 11, 2024
13d1e78
split `Options` into `SetupOptions` and `SolverOptions`
MarcBerliner Jul 11, 2024
28ed7eb
Fix pointer issues and added const
kratman Jul 11, 2024
52082fb
(feat): more idaklu options
MarcBerliner Jul 8, 2024
9fb9195
Update pybamm/solvers/idaklu_solver.py
MarcBerliner Jul 11, 2024
820e044
remove unnecessary `enumerate`
MarcBerliner Jul 11, 2024
ef4fd6b
Fix another minor warning
kratman Jul 11, 2024
fa854f9
bug fixes, add tests
MarcBerliner Jul 12, 2024
964589c
Apply suggestions from code review
MarcBerliner Jul 12, 2024
b6dff3f
complete rebase
MarcBerliner Jul 22, 2024
82fe499
Delete Options.hpp
MarcBerliner Jul 22, 2024
d55a403
Create Options.hpp
MarcBerliner Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

## Features

- Added additional user-configurable options to the (`IDAKLUSolver`). ([#4249](https://github.com/pybamm-team/PyBaMM/pull/4249))
- Added functionality to pass in arbitrary functions of time as the argument for a (`pybamm.step`). ([#4222](https://github.com/pybamm-team/PyBaMM/pull/4222))
- Added new parameters `"f{pref]Initial inner SEI on cracks thickness [m]"` and `"f{pref]Initial outer SEI on cracks thickness [m]"`, instead of hardcoding these to `L_inner_0 / 10000` and `L_outer_0 / 10000`. ([#4168](https://github.com/pybamm-team/PyBaMM/pull/4168))
- Added `pybamm.DataLoader` class to fetch data files from [pybamm-data](https://github.com/pybamm-team/pybamm-data/releases/tag/v1.0.0) and store it under local cache. ([#4098](https://github.com/pybamm-team/PyBaMM/pull/4098))
Expand Down
Loading
Loading