Added new test infrastructure #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santacodes
requested review from
brosaplanella,
Saransh-cpp,
agriyakhetarpal and
arjxn-py
16 tasks
|
Nice! I'll get to this once the tests pass. |
The tests are failing because the git initialisation hooks are not added yet, I left it out since this PR was getting too long and was thinking of making a new PR for the hooks, do you want me to add them in this same PR? |
|
I think it would be better to create and merge a PR for git initialization before this PR goes in/is reviewed. |
|
The tests are now passing after the git initialisation hooks are merged, I will be adding the patch as I mentioned here to flag out the |
{{cookiecutter.project_name}}/tests/generated_project_tests/test_entry_points.py
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/tests/generated_project_tests/test_entry_points.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agriya Khetarpal <[email protected]>
Saransh-cpp
requested changes
Jul 24, 2024
...ookiecutter.__project_slug}}/{% if cookiecutter.backend == "hatch" %}_version.pyi{% endif %}
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/version.py
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/__init__.py
Outdated
Show resolved
Hide resolved
…g}}/{% if cookiecutter.backend == "hatch" %}_version.pyi{% endif %}
Co-authored-by: Saransh Chopra <[email protected]>
Saransh-cpp
reviewed
Jul 24, 2024
...}}/src/{{cookiecutter.__project_slug}}/{% if cookiecutter.hatch_vcs %}_version.py{% endif %}
Outdated
Show resolved
Hide resolved
Saransh-cpp
requested changes
Jul 24, 2024
{{cookiecutter.project_name}}/.github/workflows/test_on_push.yml
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/.github/workflows/test_on_push.yml
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/.github/workflows/test_on_push.yml
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/.github/workflows/test_on_push.yml
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/.github/workflows/test_on_push.yml
Outdated
Show resolved
Hide resolved
Saransh-cpp
requested changes
Jul 26, 2024
{{cookiecutter.project_name}}/tests/generated_project_tests/test_entry_points.py
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/tests/generated_project_tests/test_entry_points.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agriya Khetarpal <[email protected]>
santacodes
force-pushed
the
newtestinfra
branch
3 times, most recently
from
1c7e057
to
e2e2896
Compare
agriyakhetarpal
approved these changes
Jul 29, 2024
{{cookiecutter.project_name}}/tests/generated_project_tests/test_entry_points.py
Show resolved
Hide resolved
brosaplanella
approved these changes
Jul 29, 2024
Merged
arjxn-py
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Thanks @santacodes, overall looks good.
Some minor suggestions. Should be good to merge after one final review from @Saransh-cpp.
Co-authored-by: Arjun Verma <[email protected]>
Saransh-cpp
requested changes
Jul 31, 2024
{{cookiecutter.project_name}}/src/{{cookiecutter.__project_slug}}/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Saransh Chopra <[email protected]>
Co-authored-by: Saransh Chopra <[email protected]>
Saransh-cpp
approved these changes
Jul 31, 2024
santacodes
added a commit
that referenced
this pull request
Aug 1, 2024
This is a follow-up on PR #29, the template has been completely migrated to `copier`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated
nox sessionsinsideprojectandtemplate.project:project-teststests the units inside thepybamm_cookiecutterproject, andtemplate-teststests thecookiecutter templatefor a proper generation.template: once a user generates a project (lets call it agenerated project), thegenerated projecthas twonox sessionsfor the tests,generated-project-testswhich tests all the units inside thegenerated projectanduser-testswhich executes the test cases added by a user for their respective code.CI job to test the
generated projectgenerated projectis added in the workflow, which generates a project using the cookiecutter template and runs the tests contained in thegenerated projectto test if theentry pointsand other units are working as intended.doctestsandcoverage.Note
The tests running inside
generated projectwill fail at the last step as a hook is yet to be configured to initialisegitinside the template using apost_gen_projectscript, I thought this PR was getting too long to be reviewed so I left that out for a separate one. Also I usedpipxto run the tests inside thegenerated projectbecause nox wasn't working when changing the working directory to thegenerated project.Subtask #26