Migrated to copier #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santacodes
requested review from
brosaplanella,
Saransh-cpp,
agriyakhetarpal and
arjxn-py
16 tasks
|
Thanks for taking the initiative to put up this PR early! I think it will be easier to review once we merge #29 so that the diff gets cleaner (and once you add the template generation tests using |
template/{% if ci == 'gitlab' %}.gitlab-ci.yml{% endif %}.jinja
Outdated
Show resolved
Hide resolved
Co-authored-by: Agriya Khetarpal <[email protected]>
santacodes
force-pushed
the
copier
branch
2 times, most recently
from
315a5ee
to
6ed4eb8
Compare
There was a problem hiding this comment.
Thanks, @santacodes! Could you please fix the conflicts? Happy to approve once the conflicts and the previous conversations are addressed.
Co-authored-by: Agriya Khetarpal <[email protected]>
brosaplanella
approved these changes
Aug 1, 2024
agriyakhetarpal
approved these changes
Aug 1, 2024
Co-authored-by: Agriya Khetarpal <[email protected]>
arjxn-py
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Looks good @santacodes, this one was fast 🚀
You've tested this locally too, right?
Yes I did test it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on PR #29, the template has been completely migrated to
copieras copier is under active development and is better maintained thancookiecutter.While migrating to
copierI faced some issues and thought I would mention them here, firstly in thecopier.yml(default configuration file) we cannot add our variables or constants and set their values like we did forcookiecutterfor__project_slugand__year. To tackle this problem, I added a prompt forproject_slugand replaced the__yearinstances with time labels derived fromjinja2_time.TimeExtension.As of now the generated project using
copierworks well and the tests within the generated project are all set, though I have yet to add the template generation tests. For tests I would be usingpytest-copielinked here which is almost the same aspytest-cookiesthat we are currently using.Usage
To generate a project in a directory called
test/you would need to perform -Additional Notes
I will be working on these template generation test cases with all the
build-backendsand also thecli. The CLI would wrap everything and just a single command would set up the working directory with project files.Sub-task #26