Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to hatchling #1297

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Oct 7, 2022

Moving over to using pypa/hatch's hatching.

Removed the [mypy] extra as it wasn't maintained and wasn't correct.

@henryiii henryiii marked this pull request as draft October 7, 2022 14:18
@henryiii
Copy link
Contributor Author

henryiii commented Oct 8, 2022

Sorry! I tried to add that last commit via the web editor (the WebAssembly one you get by pressing the period key) and it pushed it to master instead. Reverted. 😳

@henryiii
Copy link
Contributor Author

henryiii commented Oct 8, 2022

Does Cirrus have isolated builds disabled? Not sure why it's not picking up hatchling. It could be added - but why doesn't it pick it up?

.cirrus.yml Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

henryiii commented Oct 8, 2022

Something seems broken with homebrew * isolated installs on M1. Vaguely thought I remember hearing about that somewhere else.

@joerick
Copy link
Contributor

joerick commented Oct 10, 2022

Yeah I can recreate that locally, too. Seems it only happens on homebrew python.

https://gist.github.com/joerick/42e9e31ceb5d1dfe43c69fb6a59436e2#file-gistfile1-txt-L5541-L5551

@henryiii
Copy link
Contributor Author

Yeah, I'm quite sure I saw a discussion somewhere that homebrew is patching Python in such a way that isolated builds are broken. Needs to be reported and fixed. I can try to do it, but will take a week or so before I can get to it.

@ofek
Copy link
Contributor

ofek commented Oct 23, 2022

There are conflicts btw

@ofek
Copy link
Contributor

ofek commented Dec 5, 2023

There are conflicts again

@ofek
Copy link
Contributor

ofek commented Apr 22, 2024

Maybe one more try? 😅

@henryiii henryiii force-pushed the henryiii/chore/hatchling branch 4 times, most recently from cb85d22 to 8f60485 Compare April 22, 2024 06:33
@ofek
Copy link
Contributor

ofek commented Apr 22, 2024

Strange job timeout

@joerick
Copy link
Contributor

joerick commented Apr 26, 2024

Checks looks okay now, perhaps a retry fixed it. The other thing I think we'd need is an update to bin/bump_version.py, as it has references to setup.cfg. I'll push that now.

@mayeut
Copy link
Member

mayeut commented May 8, 2024

I cancelled the travis ci job (which would have failed on windows anyway)

@henryiii
Copy link
Contributor Author

henryiii commented May 9, 2024

I cancelled the travis ci job (which would have failed on windows anyway)

Is that an issue with this?

@mayeut
Copy link
Member

mayeut commented May 9, 2024

Is that an issue with this?

No, Windows has been failing the last couple builds.

@henryiii henryiii marked this pull request as ready for review May 9, 2024 21:21
@henryiii
Copy link
Contributor Author

Any objections to merging?

@henryiii henryiii merged commit 1b354cf into pypa:main May 20, 2024
15 checks passed
@henryiii henryiii deleted the henryiii/chore/hatchling branch May 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants