Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PEP 518 specification #1337

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Import PEP 518 specification #1337

merged 7 commits into from
Nov 7, 2023

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Nov 3, 2023

This relates to #955 and #1093.

I am aware of the previous attempt in #1111. This PR has smaller commits and does less. (The integration could be much better, but let's please not be perfectionistic and get the text there first; we can improve in subsequent PRs.)

@pradyunsg @pfmoore @brettcannon @CAM-Gerlach

@jeanas
Copy link
Contributor Author

jeanas commented Nov 3, 2023

By the way, I have a question: do we want to keep the JSON-schema structure?

It's presented as “for illustrative purposes only”, and it would need to be adapted when we will integrate PEP 517. I'm not sure it's worth keeping.

@pfmoore
Copy link
Member

pfmoore commented Nov 3, 2023

By the way, I have a question: do we want to keep the JSON-schema structure?

I have no personal use for it. But some people might. I'd keep it, but don't worry about updating it. If it bothers you, add a note saying it reflectes the initial definition from PEP 518 and has not been updated to incorporate later specifications, and leave it at that.

A direct copy of PEP 518 with flaws that can be fixed later by interested parties is better than a PR that tries to describe the current situation accurately but doesn't get merged 🙂

@jeanas
Copy link
Contributor Author

jeanas commented Nov 3, 2023

OK, I'll leave it.

@pradyunsg pradyunsg added this pull request to the merge queue Nov 7, 2023
Merged via the queue into pypa:main with commit 9d06acf Nov 7, 2023
4 checks passed
@pradyunsg
Copy link
Member

Thanks @jeanas! ^>^

@jeanas jeanas deleted the pep518 branch November 8, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants