-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A unified pyproject.toml specification #1396
Conversation
… to match new content Adjust references accordingly.
Move the description of the tool table to its own section, and use consistent titles and labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice merge of the 2 specs. I would suggest putting the note at the top to identify the history of the 2 PEPs.
Co-authored-by: Carol Willing <[email protected]>
(Fixing the merge conflict with #1395.) |
Given that 2 people approved, is this ready to go? I'm asking because there is now #1414 building on top. |
Gentle ping? @willingc? |
IIUC, this is approved already and reviewed by multiple people -- trusting the group here and marking this into the queue without doing a review myself. |
Thank you @willingc, @sinoroc and @pradyunsg! |
@pradyunsg However, we need redirects in the RTD config to keep the old links working. (Sorry, I was sure I had mentioned this in the PR description.) Namely, from Also, I'm puzzled because I thought the GitHub merge queue was supposed to check the merged result, but CI passed on this PR even though it conflicts with some of @sinoroc's work on |
See also #1434, would it be okay to keep the We're relying on it to build PEP 621 in the PEPs repo via intersphinx. And/or we can fix PEP 621 to use the new ref. But it might be worth keeping the old refs to avoid breaking intersphinx for other people/avoid linkrot. (We usually do this in https://github.com/python/devguide.) |
Some updates here:
Opened #1437.
I've figured that out — it's pretty nasty. See #1438.
This is being discussed in #1434. |
There are currently two specifications describing
pyproject.toml
, Declaring build system dependencies and Declaring project metadata. This split corresponds to history: first PEP 518 came, then PEP 621.The two specifications are closely related (they define tables of the same file), and it's also slightly confusing to have the
[tool]
table defined in the "Declaring build system dependencies" spec. This PR proposes a unified spec.Each commit is atomic so you can check that I didn't sneak in spec changes :)
📚 Documentation preview 📚: https://python-packaging-user-guide--1396.org.readthedocs.build/en/1396/