Skip to content

Fix: CI failure (Linkcheck) #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Fix: CI failure (Linkcheck) #1868

merged 2 commits into from
Jun 18, 2025

Conversation

Daksh2000
Copy link

@Daksh2000 Daksh2000 commented Jun 1, 2025

@Daksh2000 Daksh2000 marked this pull request as draft June 1, 2025 12:43
@Daksh2000 Daksh2000 changed the title Empty Commit to check CI failure Fix: CI failure (Linkcheck) Jun 1, 2025
@Daksh2000 Daksh2000 marked this pull request as ready for review June 1, 2025 13:08
@webknjaz
Copy link
Member

webknjaz commented Jun 1, 2025

This needs justification. Why ignore it? Why not scope to a specific URL? Etc.

@webknjaz
Copy link
Member

webknjaz commented Jun 1, 2025

FTR the empty commit didn't trigger the main CI run since it wasn't approved.

@Daksh2000
Copy link
Author

This needs justification. Why ignore it? Why not scope to a specific URL? Etc.

HI @webknjaz , from what I could gather upon researching , that redhat blocks the request maybe because of missing headers , I couldn't dig down deeper as the articles on redhat requires some sort of subscription to access,
I have (for now) changed the generic url to the specific one , I am open to any suggestion on this issue.

@abravalheri
Copy link
Contributor

Thanks @Daksh2000.

I also saw this problem in #1867 (comment).

@webknjaz webknjaz enabled auto-merge June 18, 2025 07:45
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry it took so long to get back to you. Let's try merging.

Though, if there's alternative web pages that work, I'd normally prefer replacing the links instead of maintaining a list of ignores.

@webknjaz webknjaz added this pull request to the merge queue Jun 18, 2025
Merged via the queue into pypa:main with commit 2b77c91 Jun 18, 2025
7 checks passed
@Daksh2000
Copy link
Author

Hey, sorry it took so long to get back to you. Let's try merging.

Though, if there's alternative web pages that work, I'd normally prefer replacing the links instead of maintaining a list of ignores.

@webknjaz , yup , totally agree with your view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants