Adjust path_to_url et al. to produce the same results on Python 3.14+ #13423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
commented
Jun 12, 2025
| return urllib.request.pathname2url(urllib.request.url2pathname(part)) | ||
| ret = urllib.request.pathname2url(urllib.request.url2pathname(part)) | ||
| if sys.version_info >= (3, 14): | ||
| ret = ret.removeprefix("//") |
There was a problem hiding this comment.
I am not proud of this :(
There was a problem hiding this comment.
It wasn't obvious to me how else to do this either 🙁
|
With no other feedback, are you planning to remove draft status from this and add a small news item? I tested this locally and it appears to be good, but because it's slightly changing the behavior of brittle path functions I think there should be a small bug fix note. |
|
Can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/cpython#125974 and #13138 (comment)
This makes the tests pass on Fedora with Python 3.14.0b2 (except test_get_index_content_directory_append_index, which segfaults python/cpython#135448)