Implement localisation support

[youtux]

Fixes #397
Supersedes #345

Checklist:

• Find all usages of keyword and check if we need to replace them with keyword_type

[youtux]

@jsa34 mind reviewing this too?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (c92f8a6) to head (06b4cca).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   95.63%   95.64%   +0.01%     
==========================================
  Files          54       54              
  Lines        2083     2091       +8     
  Branches      231      230       -1     
==========================================
+ Hits         1992     2000       +8     
  Misses         55       55              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jsa34]

There are some places where keywords are hardcoded, but I needed to resolve these for #727.

This PR should fix this issue so that the gherkin terminal reporter and cucumber json out is using the desired keywords from the feature file, rather than assuming

[jsa34]

We should include the language in the cucumber json output.

https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature
https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature.ndjson

This is example of a minimal out that is cucumber-spec-compliant, and as no language is specified, it defaults to "en" in this example, but obviously we should pass the value coming from the gherkin parser.

[jsa34]

See comments in the PR

[jsa34]

Also resolves #179

[jsa34]

I also forgot an example and change log entry: it would be helpful to demonstrate how to specify the language in the feature file

[jsa34]

There is another type to map: Conjunction (And, But and *)

[youtux]

I know, but that's just a "tokenizer" type, not a semantic one, that's why I didn't include it here

[youtux]

We should include the language in the cucumber json output.

https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature.ndjson

This is example of a minimal out that is cucumber-spec-compliant, and as no language is specified, it defaults to "en" in this example, but obviously we should pass the value coming from the gherkin parser.

Do you know if there is a specification somewhere for Cucumber JSON output?

[youtux]

I also forgot an example and change log entry: it would be helpful to demonstrate how to specify the language in the feature file

yes I forgot indeed, added in 342cf5e

[jsa34]

We should include the language in the cucumber json output.
https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature https://github.com/cucumber/compatibility-kit/blob/main/devkit/samples/minimal/minimal.feature.ndjson
This is example of a minimal out that is cucumber-spec-compliant, and as no language is specified, it defaults to "en" in this example, but obviously we should pass the value coming from the gherkin parser.

Do you know if there is a specification somewhere for Cucumber JSON output?

Messages/JSON:
https://github.com/cucumber/messages/tree/main/jsonschema

and legacy JSON:
https://github.com/cucumber/cucumber-json-schema/tree/main/schemas

[jsa34]

I think the parser test needs simplifying otherwise it will be a maintenance nightmare.
Perhaps just fix for this and then I will raise a PR to make the test more focussed.

[youtux]

I think the parser test needs simplifying otherwise it will be a maintenance nightmare. Perhaps just fix for this and then I will raise a PR to make the test more focussed.

Agree, but I think that once gherkin-official v30.0.0 is released, we can remove most of the classes in gherkin_parser.py, so let's wait for that one.

Can you check this again?

[jsa34]

All good to me now :)