Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode keywords #727

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Oct 20, 2024

Propogate keywords from gherkin parser to allow for internationalisation and using valid aliases for keywords

This was referenced Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (00916ff) to head (961f98a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   95.60%   95.63%   +0.02%     
==========================================
  Files          54       54              
  Lines        2071     2083      +12     
  Branches      231      231              
==========================================
+ Hits         1980     1992      +12     
  Misses         55       55              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsa34
Copy link
Collaborator Author

jsa34 commented Oct 20, 2024

Along with #725 , this will supersede #343 and #345

Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding tests where we use an alternative to "Scenario Outline"? I think "Scenario Examples" should be an accepted alternative

@jsa34
Copy link
Collaborator Author

jsa34 commented Oct 20, 2024

Mind adding tests where we use an alternative to "Scenario Outline"? I think "Scenario Examples" should be an accepted alternative

Done :)

youtux
youtux previously approved these changes Oct 20, 2024
@youtux youtux enabled auto-merge October 20, 2024 12:32
@youtux youtux disabled auto-merge October 20, 2024 12:32
@youtux
Copy link
Contributor

youtux commented Oct 20, 2024

This will need a change log entry too right?

Add changes to use gherkin keywords from parser
@jsa34
Copy link
Collaborator Author

jsa34 commented Oct 20, 2024

Wasn't quite sure how to word this, but added a change log entry. Feel free to suggest clearer wording!

Clearer maybe?
Missing bracket
@youtux youtux enabled auto-merge October 20, 2024 13:00
@youtux youtux merged commit c92f8a6 into pytest-dev:master Oct 20, 2024
9 checks passed
@jsa34 jsa34 deleted the propogate-keywords-from-parser branch October 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants