-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't hardcode keywords #727
Don't hardcode keywords #727
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 95.60% 95.63% +0.02%
==========================================
Files 54 54
Lines 2071 2083 +12
Branches 231 231
==========================================
+ Hits 1980 1992 +12
Misses 55 55
Partials 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding tests where we use an alternative to "Scenario Outline"? I think "Scenario Examples" should be an accepted alternative
Done :) |
This will need a change log entry too right? |
Add changes to use gherkin keywords from parser
Wasn't quite sure how to word this, but added a change log entry. Feel free to suggest clearer wording! |
Clearer maybe?
Missing bracket
Propogate keywords from gherkin parser to allow for internationalisation and using valid aliases for keywords