Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type-hints to BaseLearner #374

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

basnijholt
Copy link
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt force-pushed the type-hint-base_learner branch from 1ace06f to b91ef59 Compare October 12, 2022 04:18
@basnijholt basnijholt force-pushed the type-hint-base_learner branch from b91ef59 to b6c689f Compare October 12, 2022 04:44
@basnijholt basnijholt mentioned this pull request Oct 12, 2022
* Add type-annotations to Runner

* Add more type-hints

* Redo typing of ExecutorTypes and FutureTypes

* move around functions

* do not import from _asyncio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant