Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125933: Add ARIA labels to select elements in the version switcher #125934

Merged
merged 2 commits into from
Oct 24, 2024
Merged

gh-125933: Add ARIA labels to select elements in the version switcher #125934

merged 2 commits into from
Oct 24, 2024
+2 −2

Conversation

Privat33r-dev
Copy link
Contributor

@Privat33r-dev Privat33r-dev commented Oct 24, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 24, 2024
Closed
@Privat33r-dev Privat33r-dev changed the title GH-125933 Add labels to select elements for documentation GH-125933 Add labels to select elements Oct 24, 2024
@Privat33r-dev Privat33r-dev changed the title GH-125933 Add labels to select elements GH-125933 Add labels to select elements (docs) Oct 24, 2024
@AA-Turner AA-Turner changed the title GH-125933 Add labels to select elements (docs) gh-125933: Add labels to select elements in the version switcher Oct 24, 2024
@AA-Turner AA-Turner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Oct 24, 2024
@hugovk hugovk changed the title gh-125933: Add labels to select elements in the version switcher gh-125933: Add ARIA labels to select elements in the version switcher Oct 24, 2024
@Privat33r-dev @hugovk
make version lowercase
39b600f 
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
hugovk approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Privat33r-dev
Copy link
Contributor Author

Thank you for quick review! 👍🏻

@hugovk hugovk merged commit 1306f33 into python:main Oct 24, 2024
26 checks passed
@miss-islington-app
Copy link

Thanks @Privat33r-dev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2024
@Privat33r-dev @hugovk @miss-islington
pythongh-125933: Add ARIA labels to select elements in the version sw…
6d7c090 
…itcher (pythonGH-125934)

(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2024
@Privat33r-dev @hugovk @miss-islington
pythongh-125933: Add ARIA labels to select elements in the version sw…
9afc087 
…itcher (pythonGH-125934)

(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2024

GH-125938 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 24, 2024

GH-125939 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 24, 2024
hugovk added a commit that referenced this pull request Oct 24, 2024
@miss-islington @Privat33r-dev @hugovk
[3.13] gh-125933: Add ARIA labels to select elements in the version s…
92d301e 
…witcher (GH-125934) (#125938)

gh-125933: Add ARIA labels to select elements in the version switcher (GH-125934)
(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 24, 2024
@miss-islington @Privat33r-dev @hugovk
[3.12] gh-125933: Add ARIA labels to select elements in the version s…
31ff9e5 
…witcher (GH-125934) (#125939)

gh-125933: Add ARIA labels to select elements in the version switcher (GH-125934)
(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@Privat33r-dev Privat33r-dev deleted the feature/html-accessibility branch October 24, 2024 21:43
@hugovk
Copy link
Member

hugovk commented Oct 27, 2024

This PR only applies to the docs previews on Read the Docs, we'll need a similar one in the https://github.com/python/docsbuild-scripts repo to take effect on https://docs.python.org.

Please could you open a PR over there too?

Privat33r-dev added a commit to Privat33r-dev/docsbuild-scripts that referenced this pull request Oct 28, 2024
@Privat33r-dev
Add ARIA labels to select elements in the version switcher
6b0b2b7 
Fix in CPython didn't apply here.

python/cpython#125934
@Privat33r-dev Privat33r-dev mentioned this pull request Oct 28, 2024
Merged
@Privat33r-dev
Copy link
Contributor Author

This PR only applies to the docs previews on Read the Docs, we'll need a similar one in the https://github.com/python/docsbuild-scripts repo to take effect on https://docs.python.org.

Please could you open a PR over there too?

Sure, python/docsbuild-scripts#223

Thank you for explanation and guidance. Also it makes me wonder: why don't buildscripts take templates from the same place as the Python's docs?

@hugovk
Copy link
Member

hugovk commented Oct 28, 2024

Legacy reasons :) docsbuild-scripts came first, and they're both getting the data about what to put into the language/version switchers from different places.

There's not much overlap between these two files, and the RTD stuff is still work-in-progress, so it's probably better to let it settle first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ARIA labels to improve documentation accessibility
3 participants
@Privat33r-dev @hugovk @AA-Turner