Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-125933: Add ARIA labels to select elements in the version switcher #125934

Merged
merged 2 commits into from
Oct 24, 2024
Merged

gh-125933: Add ARIA labels to select elements in the version switcher #125934

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b32424
Add labels to select elements for documentation
Privat33r-dev Oct 24, 2024
39b600f
make version lowercase
Privat33r-dev Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/tools/static/rtd_switcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
document.addEventListener("readthedocs-addons-data-ready", function(event) {
const config = event.detail.data()
const versionSelect = `
<select id="version_select">
<select id="version_select" aria-label="Python Version">
Privat33r-dev marked this conversation as resolved.
Show resolved Hide resolved
${ config.versions.active.map(
(version) => `
<option
Expand All @@ -25,7 +25,7 @@
languages = languages.sort((a, b) => a.language.name.localeCompare(b.language.name));

const languageSelect = `
<select id="language_select">
<select id="language_select" aria-label="Language">
${ languages.map(
(translation) => `
<option
Expand Down
Loading