Skip to content

Conversation

@ascodeasice
Copy link
Contributor

#631

pre-commit 的 powrap 有動到一些我沒有翻譯的文字,如果需要將它們改回原本的樣子,我也可以修改

@mattwang44
Copy link
Collaborator

mattwang44 commented Sep 16, 2025

@ascodeasice

  • 沒關係先不用改,不知為何今年初開始原文 merge 進來和 powrap (pre-commit hook) 的 formatting 方式不同所以都會改動到,我還沒找到原因,但這不影響 build
  • 有 conflict 要請你先修掉歐
  • btw conflict 修完後如果 CI 還是失敗的話會是已知問題(我太早把 github action 的 python 升到 3.14 但 ubuntu 22 image 上還沒有 python 3.14,要再等我修一下)

@mattwang44 mattwang44 self-requested a review September 16, 2025 11:33
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review the first half

Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 2

@mattwang44
Copy link
Collaborator

btw conflict 修完後如果 CI 還是失敗的話會是已知問題(我太早把 github action 的 python 升到 3.14 但 ubuntu 22 image 上還沒有 python 3.14,要再等我修一下)

這個我修掉了,可以再 rebase 到最新的 3.14 上

@mattwang44
Copy link
Collaborator

Hi @ascodeasice,
想請問你會繼續修這隻 PR 嗎?還是我可以接手改動呢?

@ascodeasice
Copy link
Contributor Author

@mattwang44
非常不好意思,還是麻煩你進行改動好了,感謝

@mattwang44 mattwang44 self-assigned this Nov 7, 2025
@mattwang44 mattwang44 marked this pull request as draft November 7, 2025 10:37
@mattwang44 mattwang44 marked this pull request as ready for review November 7, 2025 13:26
@mattwang44 mattwang44 merged commit 2adc9e1 into python:3.14 Nov 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants