[hyperactor] extensible configuration with attributes #229
+441
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration. The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.) We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized: ``` let config = config::global::lock(); let _guard = config.override_key(crate::config::MESSAGE_ACK_EVERY_N_MESSAGES, 1); ``` Differential Revision: [D76426286](https://our.internmc.facebook.com/intern/diff/D76426286/) [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 11, 2025
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration. The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.) We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized: ``` let config = config::global::lock(); let _guard = config.override_key(crate::config::MESSAGE_ACK_EVERY_N_MESSAGES, 1); ``` Differential Revision: [D76426286](https://our.internmc.facebook.com/intern/diff/D76426286/) ghstack-source-id: 289668836 Pull Request resolved: #229
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76426286 |
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration. The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.) We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized: ``` let config = config::global::lock(); let _guard = config.override_key(crate::config::MESSAGE_ACK_EVERY_N_MESSAGES, 1); ``` Differential Revision: [D76426286](https://our.internmc.facebook.com/intern/diff/D76426286/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76426286 |
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration. The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.) We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized: ``` let config = config::global::lock(); let _guard = config.override_key(crate::config::MESSAGE_ACK_EVERY_N_MESSAGES, 1); ``` Differential Revision: [D76426286](https://our.internmc.facebook.com/intern/diff/D76426286/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76426286 |
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration. The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.) We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized: ``` let config = config::global::lock(); let _guard = config.override_key(crate::config::MESSAGE_ACK_EVERY_N_MESSAGES, 1); ``` Differential Revision: [D76426286](https://our.internmc.facebook.com/intern/diff/D76426286/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D76426286 |
|
This pull request has been merged in d80b143. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Implement hyperactor configuration with an attribute dictionary. This makes the configuration extensible -- downstream crates can define their own keys -- and provides a uniform way to define, access, store, and load hyperactor related configuration.
The base hyperactor configuration is defined in terms of a set of keys in the config crate. The config crate also implements defaults for these. (As a future change, we should consider including defaults in the base attribute dictionary implementation.)
We also provide an improved overloading API for tests, wherein individual keys can be directly overriden, and correctly ensures that tests are serialized:
Differential Revision: D76426286