[hyperactor] attribute defaults #233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
[ghstack-poisoned]
This was referenced Jun 11, 2025
mariusae
added a commit
that referenced
this pull request
Jun 11, 2025
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
ghstack-source-id: 289709203
Pull Request resolved: #233
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76438138 |
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
[ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #233 An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`. Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax: ``` declare_attrs! { /// My key. pub attr MY_KEY: u64 = 1; } let attrs = Attrs::new(); assert_eq!(attrs[MY_KEY], 1); attrs[MY_KEY] = 2; assert_eq!(attrs[MY_KEY], 2); ``` With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables. Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)! ghstack-source-id: 289710685
|
This pull request was exported from Phabricator. Differential Revision: D76438138 |
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
[ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #233 An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`. Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax: ``` declare_attrs! { /// My key. pub attr MY_KEY: u64 = 1; } let attrs = Attrs::new(); assert_eq!(attrs[MY_KEY], 1); attrs[MY_KEY] = 2; assert_eq!(attrs[MY_KEY], 2); ``` With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables. ghstack-source-id: 289712267 Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
|
This pull request was exported from Phabricator. Differential Revision: D76438138 |
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
[ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 11, 2025
Pull Request resolved: #233 An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`. Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax: ``` declare_attrs! { /// My key. pub attr MY_KEY: u64 = 1; } let attrs = Attrs::new(); assert_eq!(attrs[MY_KEY], 1); attrs[MY_KEY] = 2; assert_eq!(attrs[MY_KEY], 2); ``` With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables. ghstack-source-id: 289754395 Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
|
This pull request was exported from Phabricator. Differential Revision: D76438138 |
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`.
Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax:
```
declare_attrs! {
/// My key.
pub attr MY_KEY: u64 = 1;
}
let attrs = Attrs::new();
assert_eq!(attrs[MY_KEY], 1);
attrs[MY_KEY] = 2;
assert_eq!(attrs[MY_KEY], 2);
```
With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
[ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 13, 2025
Pull Request resolved: #233 An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling `contains_key`. Along with this, we implement `Index` and `IndexMut`, allowing a natural syntax: ``` declare_attrs! { /// My key. pub attr MY_KEY: u64 = 1; } let attrs = Attrs::new(); assert_eq!(attrs[MY_KEY], 1); attrs[MY_KEY] = 2; assert_eq!(attrs[MY_KEY], 2); ``` With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables. ghstack-source-id: 290144041 Differential Revision: [D76438138](https://our.internmc.facebook.com/intern/diff/D76438138/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76438138/)!
|
This pull request was exported from Phabricator. Differential Revision: D76438138 |
|
This pull request has been merged in 45860ad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
An attribute with a default returns the default value whenever an attribute does not exist in a dictionary. A caller can distinguish between a default and a set value by calling
contains_key.Along with this, we implement
IndexandIndexMut, allowing a natural syntax:With this, we can now simplify configs to maintaining a global attribute dictionary, and populating this by default from environment variables.
Differential Revision: D76438138
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!