Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For review only: Build torch_tensorrt for jetpack6.0, do not merge #3139

Open
wants to merge 2 commits into
base: release/2.4
Choose a base branch
from

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Sep 2, 2024
@github-actions github-actions bot added the component: build system Issues re: Build system label Sep 2, 2024
@lanluo-nvidia lanluo-nvidia changed the title Lluo/play around jetson For review only: Build torch_tensorrt for jetpack6.0, do not merge Sep 2, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 2, 2024 22:04
@@ -0,0 +1,92 @@
workspace(name = "Torch-TensorRT")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the MODULE.bazel format now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narendasan
since there is only torch2.4 nvidia wheel downloadable, so I tested this change on top of the release/2.4 branch which is still using the WORKSPACE.
I will change to the main branch using MODULE.bazel once torch2.5 nvidia wheel is available for download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants