Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade modelopt #3160

Merged
merged 5 commits into from
Sep 16, 2024
Merged

upgrade modelopt #3160

merged 5 commits into from
Sep 16, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

upgrade modelopt

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this Sep 13, 2024
@lanluo-nvidia lanluo-nvidia added WIP Work is in progress, pull request should not be merged yet and removed cla signed labels Sep 13, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: build system Issues re: Build system labels Sep 13, 2024
@HolyWu
Copy link
Contributor

HolyWu commented Sep 14, 2024

Besides CI failure, I think torchtrt won't need the onnx submodule of modelopt. So instead of nvidia-modelopt[all] you can use nvidia-modelopt[deploy,hf,torch] to save some installation space and time. Also don't forget

or Version(metadata.version("nvidia-modelopt")) < Version("0.16.1"),
"modelopt 0.16.1 or later is required Int8 quantization is supported in modelopt since 0.16.1 or later",

@lanluo-nvidia lanluo-nvidia removed the WIP Work is in progress, pull request should not be merged yet label Sep 14, 2024
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 15, 2024 17:21
@lanluo-nvidia lanluo-nvidia merged commit dbc41ce into main Sep 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: build system Issues re: Build system component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants