Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade modelopt #3160

Merged
merged 5 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dynamic = ["version"]

[project.optional-dependencies]
torchvision = ["torchvision >=0.20.dev,<0.21.0"]
quantization = ["nvidia-modelopt[all]>=0.15.1"]
quantization = ["nvidia-modelopt[deploy,hf,torch]~=0.17.0"]
monitoring-tools = ["rich >= 13.7.1"]
jupyter = ["rich[jupyter] >= 13.7.1"]

Expand Down
6 changes: 4 additions & 2 deletions tests/py/dynamo/models/test_models_export.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# type: ignore
import importlib
import platform
import unittest
from importlib import metadata

Expand Down Expand Up @@ -251,8 +252,9 @@ def calibrate_loop(model):

@unittest.skipIf(
not importlib.util.find_spec("modelopt")
or Version(metadata.version("nvidia-modelopt")) < Version("0.16.1"),
"modelopt 0.16.1 or later is required Int8 quantization is supported in modelopt since 0.16.1 or later",
or platform.system() != "Linux"
lanluo-nvidia marked this conversation as resolved.
Show resolved Hide resolved
or Version(metadata.version("nvidia-modelopt")) < Version("0.17.0"),
"modelopt 0.17.0 or later is required, Int8 quantization is supported in modelopt since 0.17.0 or later for linux",
)
@pytest.mark.unit
def test_base_int8(ir):
Expand Down
3 changes: 1 addition & 2 deletions tests/py/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ pytest-xdist>=3.6.1
pyyaml
timm>=1.0.3
transformers==4.40.2
# TODO @lanlao-nvidia Renable when modelopt can be install properly to run the tests
# "nvidia-modelopt[all]">=0.16.1,<0.17.0
nvidia-modelopt[deploy,hf,torch]~=0.17.0
--extra-index-url https://pypi.nvidia.com
Loading