Rename fast_optimize to mock_optimize
#2599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65146794 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17367 17370 +3
=======================================
+ Hits 17365 17368 +3
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Summary: The name `optimize_acqf_mixed` conflicts with the optimizer with the same name, which is exposed in `botorch/optim/__init__.py`. This would lead to `botorch.optim.optimize_acqf_mixed` pointing to two different things. Differential Revision: D65158159
…t_manager (pytorch#2598) Summary: Pull Request resolved: pytorch#2598 This mocks the default number of iterations to 1 for `optimize_acqf_mixed_alternating`, which should speed up testing considerably when combined with the existing mocks for `scipy_minimize`. Differential Revision: D65146455
|
This pull request was exported from Phabricator. Differential Revision: D65146794 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 29, 2024
Summary: Pull Request resolved: pytorch#2599 Updates the name to clarify that this is just a mock and does not magically speed up optimization without consequences. Reviewed By: sdaulton, Balandat Differential Revision: D65146794
saitcakmak
force-pushed
the
export-D65146794
branch
from
39ca7fe
to
b6ff781
Compare
Summary: Pull Request resolved: pytorch#2599 Updates the name to clarify that this is just a mock and does not magically speed up optimization without consequences. Reviewed By: sdaulton, Balandat Differential Revision: D65146794
saitcakmak
force-pushed
the
export-D65146794
branch
from
b6ff781
to
deda7ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65146794 |
|
This pull request has been merged in c671077. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Updates the name to clarify that this is just a mock and does not magically speed up optimization without consequences.
Differential Revision: D65146794