Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fast_optimize to mock_optimize #2599

Closed
wants to merge 3 commits into from
Closed

Rename fast_optimize to mock_optimize #2599

wants to merge 3 commits into from

Commits on Oct 29, 2024

  1. Rename optimize_acqf_mixed.py to optimize_mixed.py 

    Summary: The name `optimize_acqf_mixed` conflicts with the optimizer with the same name, which is exposed in `botorch/optim/__init__.py`. This would lead to `botorch.optim.optimize_acqf_mixed` pointing to two different things.

Differential Revision: D65158159
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bd1e103 View commit details
    Browse the repository at this point in the history

  2. Add mocks for optimize_acqf_mixed_alternating in fast_optimize_contex… 

    …t_manager (pytorch#2598)

Summary:
Pull Request resolved: pytorch#2598

This mocks the default number of iterations to 1 for `optimize_acqf_mixed_alternating`, which should speed up testing considerably when combined with the existing mocks for `scipy_minimize`.

Differential Revision: D65146455
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6b45a2a View commit details
    Browse the repository at this point in the history

  3. Rename fast_optimize to mock_optimize (pytorch#2599) 

    Summary:
Pull Request resolved: pytorch#2599

Updates the name to clarify that this is just a mock and does not magically speed up optimization without consequences.

Reviewed By: sdaulton, Balandat

Differential Revision: D65146794
    @saitcakmak @facebook-github-bot
    saitcakmak authored and facebook-github-bot committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    deda7ae View commit details
    Browse the repository at this point in the history