Add unbatcher node #1416
Merged
Add unbatcher node #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1416
Note: Links to docs will display an error until the docs builds have been completed. ❌ 13 New FailuresAs of commit b771bea with merge base 62092dd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
divyanshk
reviewed
Dec 26, 2024
| self._batch_idx = 0 | ||
|
|
||
| def next(self) -> T: | ||
| while self._batch_idx >= len(self._batch): |
There was a problem hiding this comment.
This should be if instead of while ? i.e. if the _batch_idx overshoots the current _batch, get a new _batch and reset _batch_idx to 0.
EDIT: while also works though, in case the next batch if of size 0 and we want to skip that too.
There was a problem hiding this comment.
@divyanshk yes i was worried about next batch of size 0 case, although I'm assuming that's unlikely but it's an edge case none the less
|
Test failure seems unrelated, not sure what caused this but it seems weird to rely on a particular implementation of the RNG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #1415
Changes