Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ParallelEnv always creates and EnvCreator for compatibility with collectors #445

Closed
wants to merge 1 commit into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 14, 2022

Description

When setting a ParallelEnv in a remote data collector and not embedding the env maker in an EnvCreator, an error is raised.
This PR solves this issue.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2022
@vmoens vmoens added the bug Something isn't working label Oct 19, 2022
Copy link

pytorch-bot bot commented Feb 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/445

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 29 Unrelated Failures

As of commit b0fdbce with merge base 67f659c (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vmoens
Copy link
Contributor Author

vmoens commented Nov 8, 2024

Should revamp this from scratch

@vmoens vmoens closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants